public inbox for linux-iio@vger.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Lorenzo Bianconi <lorenzo@kernel.org>
Cc: linux-iio@vger.kernel.org, lorenzo.bianconi@redhat.com
Subject: Re: [PATCH] iio: imu: st_lsm6dsx: enable 833Hz sample frequency for tagged sensors
Date: Sat, 25 Apr 2020 18:05:28 +0100	[thread overview]
Message-ID: <20200425180528.75c420bb@archlinux> (raw)
In-Reply-To: <81e5660e7b7755346efefdd90f721a4b0cd63726.1587724988.git.lorenzo@kernel.org>

On Fri, 24 Apr 2020 12:44:38 +0200
Lorenzo Bianconi <lorenzo@kernel.org> wrote:

> Enable 833Hz ODR for sensors that supports tagged hw FIFO:
> - LSM6DSO/LSM6DSOX
> - LSM6DSR/LSM6DSRX
> - ASM330LHH
> 
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
Would ideally have liked a little more info on the 'why'.  Was this previously
capped by practicality - i.e. not possible to read faster or is there
something else going on here?

Don't really need to know for the applied patch though so
Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to play with it.

Thanks,

Jonathan

> ---
>  drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 21 +++++++++++++-------
>  1 file changed, 14 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> index 84d219ae6aee..e6339bbb4469 100644
> --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> @@ -27,7 +27,8 @@
>   *   - FIFO size: 4KB
>   *
>   * - LSM6DSO/LSM6DSOX/ASM330LHH/LSM6DSR/ISM330DHCX:
> - *   - Accelerometer/Gyroscope supported ODR [Hz]: 13, 26, 52, 104, 208, 416
> + *   - Accelerometer/Gyroscope supported ODR [Hz]: 13, 26, 52, 104, 208, 416,
> + *     833
>   *   - Accelerometer supported full-scale [g]: +-2/+-4/+-8/+-16
>   *   - Gyroscope supported full-scale [dps]: +-125/+-245/+-500/+-1000/+-2000
>   *   - FIFO size: 3KB
> @@ -791,7 +792,8 @@ static const struct st_lsm6dsx_settings st_lsm6dsx_sensor_settings[] = {
>  				.odr_avl[3] = { 104000, 0x04 },
>  				.odr_avl[4] = { 208000, 0x05 },
>  				.odr_avl[5] = { 416000, 0x06 },
> -				.odr_len = 6,
> +				.odr_avl[6] = { 833000, 0x07 },
> +				.odr_len = 7,
>  			},
>  			[ST_LSM6DSX_ID_GYRO] = {
>  				.reg = {
> @@ -804,7 +806,8 @@ static const struct st_lsm6dsx_settings st_lsm6dsx_sensor_settings[] = {
>  				.odr_avl[3] = { 104000, 0x04 },
>  				.odr_avl[4] = { 208000, 0x05 },
>  				.odr_avl[5] = { 416000, 0x06 },
> -				.odr_len = 6,
> +				.odr_avl[6] = { 833000, 0x07 },
> +				.odr_len = 7,
>  			},
>  		},
>  		.fs_table = {
> @@ -994,7 +997,8 @@ static const struct st_lsm6dsx_settings st_lsm6dsx_sensor_settings[] = {
>  				.odr_avl[3] = { 104000, 0x04 },
>  				.odr_avl[4] = { 208000, 0x05 },
>  				.odr_avl[5] = { 416000, 0x06 },
> -				.odr_len = 6,
> +				.odr_avl[6] = { 833000, 0x07 },
> +				.odr_len = 7,
>  			},
>  			[ST_LSM6DSX_ID_GYRO] = {
>  				.reg = {
> @@ -1007,7 +1011,8 @@ static const struct st_lsm6dsx_settings st_lsm6dsx_sensor_settings[] = {
>  				.odr_avl[3] = { 104000, 0x04 },
>  				.odr_avl[4] = { 208000, 0x05 },
>  				.odr_avl[5] = { 416000, 0x06 },
> -				.odr_len = 6,
> +				.odr_avl[6] = { 833000, 0x07 },
> +				.odr_len = 7,
>  			},
>  		},
>  		.fs_table = {
> @@ -1171,7 +1176,8 @@ static const struct st_lsm6dsx_settings st_lsm6dsx_sensor_settings[] = {
>  				.odr_avl[3] = { 104000, 0x04 },
>  				.odr_avl[4] = { 208000, 0x05 },
>  				.odr_avl[5] = { 416000, 0x06 },
> -				.odr_len = 6,
> +				.odr_avl[6] = { 833000, 0x07 },
> +				.odr_len = 7,
>  			},
>  			[ST_LSM6DSX_ID_GYRO] = {
>  				.reg = {
> @@ -1184,7 +1190,8 @@ static const struct st_lsm6dsx_settings st_lsm6dsx_sensor_settings[] = {
>  				.odr_avl[3] = { 104000, 0x04 },
>  				.odr_avl[4] = { 208000, 0x05 },
>  				.odr_avl[5] = { 416000, 0x06 },
> -				.odr_len = 6,
> +				.odr_avl[6] = { 833000, 0x07 },
> +				.odr_len = 7,
>  			},
>  		},
>  		.fs_table = {


  reply	other threads:[~2020-04-25 17:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-24 10:44 [PATCH] iio: imu: st_lsm6dsx: enable 833Hz sample frequency for tagged sensors Lorenzo Bianconi
2020-04-25 17:05 ` Jonathan Cameron [this message]
2020-04-26 14:28   ` Lorenzo Bianconi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200425180528.75c420bb@archlinux \
    --to=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=lorenzo.bianconi@redhat.com \
    --cc=lorenzo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox