Re: [PATCH v9 2/6] mfd: mp2629: Add support for mps battery charger

Lee Jones
2020-04-24T07:18:38Z

On Wed, 15 Apr 2020, Saravanan Sekar wrote:

> mp2629 is a highly-integrated switching-mode battery charge management
> device for single-cell Li-ion or Li-polymer battery.
>
> Add MFD core enables chip access for ADC driver for battery readings,
> and a power supply battery-charger driver
>
> Signed-off-by: Saravanan Sekar <sravanhome@gmail.com>
> ---
> drivers/mfd/Kconfig | 9 ++++
> drivers/mfd/Makefile | 2 +
> drivers/mfd/mp2629.c | 86 ++++++++++++++++++++++++++++++++++++++
> include/linux/mfd/mp2629.h | 19 +++++++++
> 4 files changed, 116 insertions(+)
> create mode 100644 drivers/mfd/mp2629.c
> create mode 100644 include/linux/mfd/mp2629.h

How is this driver registered?

Looks like it has device tree support. Is there another way?

> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 3c547ed575e6..85be799795aa 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -434,6 +434,15 @@ config MFD_MC13XXX_I2C
> help
> Select this if your MC13xxx is connected via an I2C bus.
>
> +config MFD_MP2629
> + tristate "Monolithic power system MP2629 ADC and Battery charger"
> + depends on I2C
> + select REGMAP_I2C
> + help
> + Select this option to enable support for monolithic power system
> + battery charger. This provides ADC, thermal, battery charger power
> + management functions on the systems.

--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog