From: Pavel Machek <pavel@ucw.cz>
To: Jonathan Albrieux <jonathan.albrieux@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Linus Walleij <linus.walleij@linaro.org>,
"open list:IIO SUBSYSTEM AND DRIVERS" <linux-iio@vger.kernel.org>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Steve Winslow <swinslow@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Jonathan Cameron <jic23@kernel.org>
Subject: Re: [PATCH 3/3] iio: magnetometer: ak8975: Add gpio reset support
Date: Fri, 29 May 2020 15:33:46 +0200 [thread overview]
Message-ID: <20200529133346.GC1339@bug> (raw)
In-Reply-To: <20200518133645.19127-4-jonathan.albrieux@gmail.com>
Hi!
> AK09911 has a reset gpio to handle register's reset. If reset gpio is
> set to low it will trigger the reset. AK09911 datasheed says that if not
> used reset pin should be connected to VID and this patch emulates this
> situation
>
> Signed-off-by: Jonathan Albrieux <jonathan.albrieux@gmail.com>
> ---
> drivers/iio/magnetometer/ak8975.c | 21 +++++++++++++++++++--
> 1 file changed, 19 insertions(+), 2 deletions(-)
>
> /*
> - * According to the datasheet the power supply rise time i 200us
> + * According to the datasheet the power supply rise time is 200us
> * and the minimum wait time before mode setting is 100us, in
> - * total 300 us. Add some margin and say minimum 500us here.
> + * total 300us. Add some margin and say minimum 500us here.
> */
> usleep_range(500, 1000);
I'd assume that datasheet added some safety margin too, and there's another one in usleep...
So I believe usleep..(300) should be okay..
Best regards,
Pavel
prev parent reply other threads:[~2020-05-29 13:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-18 13:36 [PATCH 0/3] iio: magnetometer: ak8975: Add gpio reset support Jonathan Albrieux
2020-05-18 13:36 ` [PATCH 1/3] dt-bindings: iio: magnetometer: ak8975: convert txt format to yaml Jonathan Albrieux
2020-05-18 13:36 ` [PATCH 2/3] dt-bindings: iio: magnetometer: ak8975: add gpio reset support Jonathan Albrieux
2020-05-25 8:43 ` Linus Walleij
2020-05-25 10:53 ` Jonathan Albrieux
2020-05-18 13:36 ` [PATCH 3/3] iio: magnetometer: ak8975: Add " Jonathan Albrieux
2020-05-18 14:55 ` Andy Shevchenko
2020-05-18 16:01 ` Jonathan Albrieux
2020-05-18 16:43 ` Andy Shevchenko
2020-05-18 17:43 ` Jonathan Albrieux
2020-05-18 17:51 ` Andy Shevchenko
2020-05-18 18:46 ` Jonathan Albrieux
2020-05-29 13:33 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200529133346.GC1339@bug \
--to=pavel@ucw.cz \
--cc=Jonathan.Cameron@huawei.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=jonathan.albrieux@gmail.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=swinslow@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).