From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0707C433DF for ; Sun, 31 May 2020 13:48:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A0E6D2076B for ; Sun, 31 May 2020 13:48:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590932936; bh=wKxxJ69sCKK08/CajGt2YX8NU6dfARAeeUDi0+P5S+s=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=ApDY8HlCfhG08/Yfq1NsL02pcuihq1sQaYEY74lj5ruR9zU3QIJK0K7wBEch8z2I4 ffcsZXbRhddHWvKls1XFsC/ypKTJF4IetRLwmcr1WmBqFdObLrhJHVF/JnVXN3X4vs kZYB57k+pgbVabCHaIUPNFyAJQnRBUfyzFkmze6o= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727084AbgEaNsx (ORCPT ); Sun, 31 May 2020 09:48:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:49904 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725889AbgEaNsw (ORCPT ); Sun, 31 May 2020 09:48:52 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3EB04206F1; Sun, 31 May 2020 13:48:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590932932; bh=wKxxJ69sCKK08/CajGt2YX8NU6dfARAeeUDi0+P5S+s=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=0tL0wqworscs11HLvnA+TA05Y04ORhsVNDuK8ty3U3Cf2fY4tBIF+Z0IcFDiVDhuO tIUVxBsT5pTZdzbkzIIZ3+KxNaTT2e0jhTldfcLAydhJAO/U610u1ukXFuv9WlcgvM ApvBUUD96tymMgEYdQ8ezSlnJLnvkj7rrB4owzLk= Date: Sun, 31 May 2020 14:48:48 +0100 From: Jonathan Cameron To: Rikard Falkeborn Cc: Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/6] iio: magnetometer: mmc35240: Constify struct reg_default Message-ID: <20200531144848.4af9a574@archlinux> In-Reply-To: <20200526210223.1672-7-rikard.falkeborn@gmail.com> References: <20200526210223.1672-1-rikard.falkeborn@gmail.com> <20200526210223.1672-7-rikard.falkeborn@gmail.com> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Tue, 26 May 2020 23:02:23 +0200 Rikard Falkeborn wrote: > mmc35240_reg_defaults is not modified and can be made const to allow the > compiler to put it in read-only memory. > > Before: > text data bss dec hex filename > 9759 3288 128 13175 3377 drivers/iio/magnetometer/mmc35240.o > > After: > text data bss dec hex filename > 9823 3224 128 13175 3377 drivers/iio/magnetometer/mmc35240.o > > Signed-off-by: Rikard Falkeborn Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it. Thanks, Jonathan > --- > drivers/iio/magnetometer/mmc35240.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/magnetometer/mmc35240.c b/drivers/iio/magnetometer/mmc35240.c > index 1787d656d009..f27586716b5c 100644 > --- a/drivers/iio/magnetometer/mmc35240.c > +++ b/drivers/iio/magnetometer/mmc35240.c > @@ -459,7 +459,7 @@ static bool mmc35240_is_volatile_reg(struct device *dev, unsigned int reg) > } > } > > -static struct reg_default mmc35240_reg_defaults[] = { > +static const struct reg_default mmc35240_reg_defaults[] = { > { MMC35240_REG_CTRL0, 0x00 }, > { MMC35240_REG_CTRL1, 0x00 }, > };