From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61A72C433E0 for ; Sun, 31 May 2020 14:00:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 33E4120776 for ; Sun, 31 May 2020 14:00:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590933606; bh=nm262quWmD0DcxBgdTM4rIOmm1pxgL6odqNjGb98nWc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=PglNOEDS2y907zHdxP8B4OKz3WbtumUzstucMdvuP9UDLM/hI9ptXaDk+dTK3Fcdv YbT1rMnhZiqaGcCF7YNJm8HqFs54gfD0NYy8kksbQrxdREvsp+orA6l8Cy7zhGkE4y 8z+EHxvVIy7syDGSenpiu9duTNJE+5ngNfRLiNvI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728105AbgEaOAF (ORCPT ); Sun, 31 May 2020 10:00:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:51618 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726008AbgEaOAF (ORCPT ); Sun, 31 May 2020 10:00:05 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 89C0E20723; Sun, 31 May 2020 14:00:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590933605; bh=nm262quWmD0DcxBgdTM4rIOmm1pxgL6odqNjGb98nWc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=gOV+2f4FhYq9WkWYultbMsyn5xrcsdnj2+zH9pSZGMDHnn413ieBz3LpMGwif/LLb cVt722flsxqBt7rVj9gBEUBQJcINOtWLSUqm57fc5F30euCFaeNR+GRlbnTBzZt5sw awt4WYYKKsHnnK6yAWLQdjfLM5rfHJFDrpujZjh8= Date: Sun, 31 May 2020 15:00:00 +0100 From: Jonathan Cameron To: Linus Walleij Cc: Dinghao Liu , Kangjie Lu , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , linux-iio , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] [v2] iio: magnetometer: ak8974: Fix runtime PM imbalance on error Message-ID: <20200531150000.20d1ec61@archlinux> In-Reply-To: References: <20200526104717.3181-1-dinghao.liu@zju.edu.cn> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Tue, 26 May 2020 13:13:56 +0200 Linus Walleij wrote: > On Tue, May 26, 2020 at 12:47 PM Dinghao Liu wrote: > > > When devm_regmap_init_i2c() returns an error code, a pairing > > runtime PM usage counter decrement is needed to keep the > > counter balanced. For error paths after ak8974_set_power(), > > ak8974_detect() and ak8974_reset(), things are the same. > > > > However, When iio_triggered_buffer_setup() returns an error > > code, there will be two PM usgae counter decrements. > > > > Signed-off-by: Dinghao Liu > > --- > > > > Changelog: > > > > v2: - Change 3 goto targets from "power_off" to > > "disabel_pm". Remove unused lable "power_off". > > Move 3 PM runtime related calls to the end of > > the function. > > Thanks for fixing this Dinghao! > Reviewed-by: Linus Walleij Could I have a fixes tag for this one? Thanks, Jonathan > > Yours, > Linus Walleij