From: Jonathan Cameron <jic23@kernel.org>
To: Alexandru Ardelean <alexandru.ardelean@analog.com>
Cc: <linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] iio: dac: ad5592r: remove usage of iio_priv_to_dev() helper
Date: Sun, 31 May 2020 15:32:33 +0100 [thread overview]
Message-ID: <20200531153233.2fff02e3@archlinux> (raw)
In-Reply-To: <20200525131034.230738-1-alexandru.ardelean@analog.com>
On Mon, 25 May 2020 16:10:34 +0300
Alexandru Ardelean <alexandru.ardelean@analog.com> wrote:
> This was partially removed when the mlock cleanup was done. Only one more
> call is left in the ad5592r_alloc_channels() function.
> This one is simple. We just need to pass the iio_dev object and get the
> state via iio_priv().
>
> Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to poke at.
Thanks,
Jonathan
> ---
> drivers/iio/dac/ad5592r-base.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/iio/dac/ad5592r-base.c b/drivers/iio/dac/ad5592r-base.c
> index 410e90e5f75f..272c97bb841c 100644
> --- a/drivers/iio/dac/ad5592r-base.c
> +++ b/drivers/iio/dac/ad5592r-base.c
> @@ -508,11 +508,11 @@ static void ad5592r_setup_channel(struct iio_dev *iio_dev,
> chan->ext_info = ad5592r_ext_info;
> }
>
> -static int ad5592r_alloc_channels(struct ad5592r_state *st)
> +static int ad5592r_alloc_channels(struct iio_dev *iio_dev)
> {
> + struct ad5592r_state *st = iio_priv(iio_dev);
> unsigned i, curr_channel = 0,
> num_channels = st->num_channels;
> - struct iio_dev *iio_dev = iio_priv_to_dev(st);
> struct iio_chan_spec *channels;
> struct fwnode_handle *child;
> u32 reg, tmp;
> @@ -636,7 +636,7 @@ int ad5592r_probe(struct device *dev, const char *name,
> if (ret)
> goto error_disable_reg;
>
> - ret = ad5592r_alloc_channels(st);
> + ret = ad5592r_alloc_channels(iio_dev);
> if (ret)
> goto error_disable_reg;
>
prev parent reply other threads:[~2020-05-31 14:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-25 13:10 [PATCH] iio: dac: ad5592r: remove usage of iio_priv_to_dev() helper Alexandru Ardelean
2020-05-31 14:32 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200531153233.2fff02e3@archlinux \
--to=jic23@kernel.org \
--cc=alexandru.ardelean@analog.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).