From: Dan Robertson <dan@dlrobertson.com>
To: Jonathan Cameron <jic23@jic23.retrosnub.co.uk>
Cc: Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Linus Walleij <linus.walleij@linaro.org>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
linux-iio@vger.kernel.org
Subject: Re: [PATCH v2 1/1] iio: accel: bma400: add support for bma400 spi
Date: Tue, 2 Jun 2020 02:46:50 +0000 [thread overview]
Message-ID: <20200602024650.GA16553@gothmog.test> (raw)
In-Reply-To: <20200531101345.2e50720b@archlinux>
[-- Attachment #1: Type: text/plain, Size: 1093 bytes --]
On Sun, May 31, 2020 at 10:14:06AM +0100, Jonathan Cameron wrote:
> On Sun, 31 May 2020 10:10:24 +0100
> Jonathan Cameron <jic23@kernel.org> wrote:
>
> > On Sat, 30 May 2020 19:10:10 +0000
> > Dan Robertson <dan@dlrobertson.com> wrote:
> >
> > > Add basic support for the Bosch Sensortec BMA400 3-axes ultra-low power
> > > accelerometer when configured to use SPI.
> > >
> > > Signed-off-by: Dan Robertson <dan@dlrobertson.com>
> >
> > Hi Dan.
> >
> > Code looks good, but one suggestion for a possible optimization inline.
> >
> > I did wonder if it would be possible to use standard spi regmap to
> > do this, but it seems there is only a single pad parameter for both
> > reads and writes so that won't work.
>
> Changed my mind. See below.
Yeah I had hoped for the same too.
> Applied to the togreg branch of iio.git and pushed out as testing for
> the autobuilders to play with it.
Thanks!
> Note however that we should add spi stuff to the device tree binding
> docs. That can happen as a follow up patch.
Will do.
Cheers,
- Dan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 902 bytes --]
prev parent reply other threads:[~2020-06-02 2:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-30 19:10 [PATCH v2 0/1] iio: accel: bma400: add support for bma400 spi Dan Robertson
2020-05-30 19:10 ` [PATCH v2 1/1] " Dan Robertson
2020-05-31 9:10 ` Jonathan Cameron
2020-05-31 9:14 ` Jonathan Cameron
2020-06-02 2:46 ` Dan Robertson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200602024650.GA16553@gothmog.test \
--to=dan@dlrobertson.com \
--cc=andy.shevchenko@gmail.com \
--cc=jic23@jic23.retrosnub.co.uk \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).