Re: [PATCH v8 1/2] Driver for TI HDC20x0 humidity and temperature sensors

Eugene Zaikonnikov
2020-06-11T13:02:11Z

Jonathan Cameron <Jonathan.Cameron@Huawei.com> writes:

> On Mon, 18 May 2020 19:15:27 +0000
> Eugene Zalkonnikov <ez@norphonic.com> wrote:
>
> Hi Eugene
>
>> HDC2010/2080 driver and sysfs documentation for its heater element.
>>
>
> Would be nice to have a little more info on the device for anyone reading
> the log after we commit this.
>
Ok I'll expand the description.

> There is a potential double free in the remove path due to mix of
> devm_iio_device_register and iio_device_unregister.
>
Right, overlooked this. Will changine the unregister to the managed
version suffice?

> Also, the error paths in probe don't undo the various bits of setup
> that it feels like they should. This might not matter in reality
> but the code will be more obviously correct if it is fine to reset
> the amm bit.
>
I'll add that.

--
Regards,

Eugene Zaikonnikov

Norphonic AS
Tel: +47 98 23 97 73