From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C41FC433E0 for ; Sat, 4 Jul 2020 17:19:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4981420782 for ; Sat, 4 Jul 2020 17:19:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593883148; bh=OsxmT5cTxf5QNb+/jlVqNSKLTitmbDMAOhy+OIg771E=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=QHzjW7ha7wjuaIJzkzssTP9KNaU1GhL/m3rTaDBjFdQ0u35JJeR5ipHA7lVKMMqcF v6H+xG8hXHFW67X6lst6ACrAVSUXFujeNtoIFIxNfzlOglMoK5gP4f+dvv78xW7sa+ AeghSWstDs9QDeh38UoK7++O9p/9FZ56RMixQ6fc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726682AbgGDRTH (ORCPT ); Sat, 4 Jul 2020 13:19:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:45358 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726669AbgGDRTH (ORCPT ); Sat, 4 Jul 2020 13:19:07 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2555220737; Sat, 4 Jul 2020 17:19:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593883147; bh=OsxmT5cTxf5QNb+/jlVqNSKLTitmbDMAOhy+OIg771E=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=mQLgB3Oh+4UzkmF9Z3OlTipiRcZ6enU0gNYtNG7pSvWliJeSNrCUFcrPQ4mgRGvAK OGJKzTX51oeAQ3BZujJFnU9zr1Bly3W7INPwbxIZiBwNlAIsMGKrGQlNWBkVLDbiL8 Ui4QUS7+4ho06Dr+ihsH8GIalbGdcBjgSG5z/2L4= Date: Sat, 4 Jul 2020 18:19:03 +0100 From: Jonathan Cameron To: Jacopo Mondi Cc: linux-iio@vger.kernel.org, alexandru.Ardelean@analog.com, Andy Shevchenko , Jonathan Cameron Subject: Re: [PATCH 10/23] iio:adc:max11100: Drop of_match_ptr protection / add mod_devicetable.h include Message-ID: <20200704181903.0ad2b7c5@archlinux> In-Reply-To: <20200629072809.fk2vve5ycdiwnkyk@uno.localdomain> References: <20200628123654.32830-1-jic23@kernel.org> <20200628123654.32830-11-jic23@kernel.org> <20200629072809.fk2vve5ycdiwnkyk@uno.localdomain> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Mon, 29 Jun 2020 09:28:09 +0200 Jacopo Mondi wrote: > Hi Jonathan, > On Sun, Jun 28, 2020 at 01:36:41PM +0100, Jonathan Cameron wrote: > > From: Jonathan Cameron > > > > Allows use of driver with ACPI PRP0001 base binding. > > Mostly this is about trying to avoid cut and paste of this into new > > drivers (it is a frequent review comment) rather than any > > thought that this driver might get used on an ACPI platform. > > > > The mod_devicetable.h include is to encourage best practice of including > > any header directly used within the code (here for of_match_id) > > > > Signed-off-by: Jonathan Cameron > > Cc: Jacopo Mondi > > --- > > drivers/iio/adc/max11100.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/iio/adc/max11100.c b/drivers/iio/adc/max11100.c > > index 57734f9742f6..77fcee1dddf7 100644 > > --- a/drivers/iio/adc/max11100.c > > +++ b/drivers/iio/adc/max11100.c > > @@ -9,6 +9,7 @@ > > #include > > #include > > #include > > +#include > > If we want to keep the inclusion order alphabetically sorted, > shouldn't mod_devicetable. come before module.h ? I have no idea what the 'convention' on ordering of underscores in the kernel is, so I did git grep -A1 module\.h -- drivers/ | grep mod_devicetable\.h | wc 116 232 7798 git grep -B1 module\.h -- drivers/ | grep mod_devicetable\.h | wc 52 104 3694 Which I think means we have almost twice as many cases of it being after module.h as before. Still I'm going to cynically decide to not care :) > > That apart: > Acked-by: Jacopo Mondi > Thanks, Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to poke at it. Jonathan > Thanks > j > > > #include > > #include > > > > @@ -161,7 +162,7 @@ MODULE_DEVICE_TABLE(of, max11100_ids); > > static struct spi_driver max11100_driver = { > > .driver = { > > .name = "max11100", > > - .of_match_table = of_match_ptr(max11100_ids), > > + .of_match_table = max11100_ids, > > }, > > .probe = max11100_probe, > > .remove = max11100_remove, > > -- > > 2.27.0 > >