From: Jonathan Cameron <jic23@kernel.org>
To: Colton Lewis <colton.w.lewis@protonmail.com>
Cc: linux-iio@vger.kernel.org
Subject: Re: [PATCH] iio: Correct kernel-doc inconsistency
Date: Sat, 18 Jul 2020 17:19:02 +0100 [thread overview]
Message-ID: <20200718171902.13fd2571@archlinux> (raw)
In-Reply-To: <20200715191656.29437-1-colton.w.lewis@protonmail.com>
On Wed, 15 Jul 2020 19:17:09 +0000
Colton Lewis <colton.w.lewis@protonmail.com> wrote:
> Silence documentation build warning by correcting kernel-doc comment
> for iio_dev struct.
>
> ./include/linux/iio/iio.h:574: warning: Function parameter or member 'read_buf' not described in 'iio_dev'
> ./include/linux/iio/iio.h:574: warning: Function parameter or member 'read_buf_len' not described in 'iio_dev'
>
> Signed-off-by: Colton Lewis <colton.w.lewis@protonmail.com>
Hi Colton,
Thanks for the patch, but these elements have moved and now have docs
(very recent!) See the testing branch of iio.git on git.kernel.org
Jonathan
> ---
> include/linux/iio/iio.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/linux/iio/iio.h b/include/linux/iio/iio.h
> index a1be82e74c93..48049b344e6c 100644
> --- a/include/linux/iio/iio.h
> +++ b/include/linux/iio/iio.h
> @@ -522,6 +522,8 @@ struct iio_buffer_setup_ops {
> * @flags: [INTERN] file ops related flags including busy flag.
> * @debugfs_dentry: [INTERN] device specific debugfs dentry.
> * @cached_reg_addr: [INTERN] cached register address for debugfs reads.
> + * @read_buf: [INTERN] cached register contents for debugfs reads
> + * @read_buf_len: [INTERN] length of @read_buf
> */
> struct iio_dev {
> int id;
prev parent reply other threads:[~2020-07-18 16:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-15 19:17 [PATCH] iio: Correct kernel-doc inconsistency Colton Lewis
2020-07-18 16:19 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200718171902.13fd2571@archlinux \
--to=jic23@kernel.org \
--cc=colton.w.lewis@protonmail.com \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox