From: Dan Robertson <dan@dlrobertson.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Linus Walleij <linus.walleij@linaro.org>,
linux-iio <linux-iio@vger.kernel.org>
Subject: Re: [PATCH 1/1] iio: accel: bma400: add PM_SLEEP support
Date: Mon, 20 Jul 2020 23:50:28 +0000 [thread overview]
Message-ID: <20200720235028.GA13636@nessie> (raw)
In-Reply-To: <CAHp75Vc0H0C01kBsVHfmD6QbS-6Wh3R7HCua8RQ+2vHrQUqoig@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1003 bytes --]
On Wed, Jul 15, 2020 at 08:44:59AM +0300, Andy Shevchenko wrote:
> On Wed, Jul 15, 2020 at 8:05 AM Dan Robertson <dan@dlrobertson.com> wrote:
> >
> > - Add system sleep ops if CONFIG_PM_SLEEP is set.
> > - Add attribute for setting the power mode of the
> > device.
>
> ...
>
> > -static const struct iio_chan_spec_ext_info bma400_ext_info[] = {
>
> > -};
> > -
> > -#define BMA400_ACC_CHANNEL(_axis) { \
>
> > -}
> > -
> > -static const struct iio_chan_spec bma400_channels[] = {
>
> > -};
> > -
>
> I'm not sure how this part is related.
>
> ...
Moving things around for the power mode switching endpoint.
> > +static const char * const bma400_power_modes[] = {
> > + "sleep",
> > + "low-power",
> > + "normal"
>
> Missed comma.
>
> > +};
>
> ...
>
> > +#ifdef CONFIG_PM_SLEEP
>
> __maybe_unused looks better.
Good point.
Thanks for the review! I'll address your comments in v2 of the patchset.
Cheers,
- Dan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-07-21 0:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-15 5:02 [PATCH 0/1] iio: accel: bma400: add PM_SLEEP support Dan Robertson
2020-07-15 5:02 ` [PATCH 1/1] " Dan Robertson
2020-07-15 5:44 ` Andy Shevchenko
2020-07-20 23:50 ` Dan Robertson [this message]
2020-07-20 11:23 ` Jonathan Cameron
2020-07-20 23:53 ` Dan Robertson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200720235028.GA13636@nessie \
--to=dan@dlrobertson.com \
--cc=andy.shevchenko@gmail.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox