From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1A3DC433DF for ; Sat, 1 Aug 2020 15:57:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C988D2080C for ; Sat, 1 Aug 2020 15:57:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596297464; bh=zUvyqDBhl4P1zPK45roaIEk9cGnxHAiVSJGSudhGy3s=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=wo2g3CBKX6rvpH46RmMiVZHEwpY3fqn6DZdjuH1bo52goMg62FmBhChZO2u8Pud2i yEgHOO1xjE5leRwwtvTnlJzc8HTqiHsioPQaJnlpzHyBePG/DFpQlMo+gwlDIvGvhH szjkNLONM3Obw3Xtg+Ya5JXlh9sJWs4GmOLHSj8k= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726571AbgHAP5o (ORCPT ); Sat, 1 Aug 2020 11:57:44 -0400 Received: from mail.kernel.org ([198.145.29.99]:53614 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726534AbgHAP5o (ORCPT ); Sat, 1 Aug 2020 11:57:44 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 643EE207BC; Sat, 1 Aug 2020 15:57:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596297463; bh=zUvyqDBhl4P1zPK45roaIEk9cGnxHAiVSJGSudhGy3s=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=piaS2bMFctpOgtXi4Pf6CMrWYcvQLExKQHTWc76AiGCUuIPTLF78wIPX7lLtn1M2W U1cuTprQBoWGl9W/o3tgb38VdtdlMbo2/yXrfyRUjD8CYXA5FrmBk9T9WM2SNN+JRT 0tjTbVUVRhJJbSwfm7e6igu6QK1glraRAFUkgQTk= Date: Sat, 1 Aug 2020 16:57:34 +0100 From: Jonathan Cameron To: Maxim Kochetkov Cc: Lars-Peter Clausen , Peter Meerwald-Stadler , Andy Shevchenko , linux-iio@vger.kernel.org, bigunclemax@gmail.com Subject: Re: [PATCH v3] iio: adc: ti-ads1015: fix conversion when CONFIG_PM is not set Message-ID: <20200801165714.3cccb5d7@archlinux> In-Reply-To: <20200729103523.19073-1-fido_max@inbox.ru> References: <20200729103523.19073-1-fido_max@inbox.ru> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Wed, 29 Jul 2020 13:35:23 +0300 Maxim Kochetkov wrote: > To stop conversion ads1015_set_power_state() function call unimplemented > function __pm_runtime_suspend() from pm_runtime_put_autosuspend() > if CONFIG_PM is not set. > In case of CONFIG_PM is not set: __pm_runtime_suspend() returns -ENOSYS, > so ads1015_read_raw() failed because ads1015_set_power_state() returns an > error. > > If CONFIG_PM is disabled, there is no need to start/stop conversion. > Fix it by adding return 0 function variant if CONFIG_PM is not set. > > Signed-off-by: Maxim Kochetkov > Tested-by: Maxim Kiselev > Reviewed-by: Andy Shevchenko Patch looks good, but can I have a Fixes tag for it? Thanks, Jonathan > --- > drivers/iio/adc/ti-ads1015.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/iio/adc/ti-ads1015.c b/drivers/iio/adc/ti-ads1015.c > index 5ea4f45d6bad..64fe3b2a6ec6 100644 > --- a/drivers/iio/adc/ti-ads1015.c > +++ b/drivers/iio/adc/ti-ads1015.c > @@ -316,6 +316,7 @@ static const struct iio_chan_spec ads1115_channels[] = { > IIO_CHAN_SOFT_TIMESTAMP(ADS1015_TIMESTAMP), > }; > > +#ifdef CONFIG_PM > static int ads1015_set_power_state(struct ads1015_data *data, bool on) > { > int ret; > @@ -333,6 +334,15 @@ static int ads1015_set_power_state(struct ads1015_data *data, bool on) > return ret < 0 ? ret : 0; > } > > +#else /* !CONFIG_PM */ > + > +static int ads1015_set_power_state(struct ads1015_data *data, bool on) > +{ > + return 0; > +} > + > +#endif /* !CONFIG_PM */ > + > static > int ads1015_get_adc_result(struct ads1015_data *data, int chan, int *val) > {