From: Jonathan Cameron <jic23@kernel.org>
To: Christian Eggers <ceggers@arri.de>
Cc: Pavel Machek <pavel@ucw.cz>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
<linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] iio: documentation: light: Add as73211 sysfs documentation
Date: Sun, 16 Aug 2020 10:18:44 +0100 [thread overview]
Message-ID: <20200816101844.79e1c5c5@archlinux> (raw)
In-Reply-To: <2320252.sbR73lAtI7@n95hx1g2>
On Mon, 10 Aug 2020 15:24:39 +0200
Christian Eggers <ceggers@arri.de> wrote:
> Hi Pavel,
>
> On Monday, 10 August 2020, 14:35:40 CEST, Pavel Machek wrote:
> > On Mon 2020-08-10 11:57:46, Christian Eggers wrote:
> > > On Monday, 10 August 2020, 11:00:54 CEST, Pavel Machek wrote:
> > > > Hi!
> > > >
> > > > > The driver for the as73211 light sensor provides the following not yet
> > > > > documented sysfs entries:
> > > > > - in_intensity_(x|y|z)_raw
> > > > > - in_intensity_(x|y|z)_scale
> > > > > - in_intensity_sampling_frequency(_available)
> > > > > - in_intensity_hardwaregain(_available)
> > > >
> > > > Should that be hardware_gain ?
> > >
> > > drivers/iio/industrialio-core.c:
> > > [IIO_CHAN_INFO_HARDWAREGAIN] = "hardwaregain",
> >
> > Yep. Fix that before people start to really use it.
> it's too late! IIO_CHAN_INFO_HARDWAREGAIN was introduced back in 2012. My
> patch only adds "hardwaregain" in a new context (of "intensity").
Why do you think that is broken?
It was a deliberate decision to try and stop putting _'s into new
elements because it was making userspace parsing harder. hardwaregain
is a single 'token' in that file name.
We are stuck with some older forms that predate that decision
and a few that are closely related to existing elements and hence
had to maintain the 'spacing'. Those have to be special cased
in tokenizing code. We don't want to introduced any more though.
One or two may have snuck through when we weren't awake of course.
Jonathan
>
> >
> Pavel
>
> regards
> Christian
>
>
>
>
> ________________________________
> [http://assets.arri.com/media/sign/2020-04-03-E-mail-signature-Stellar2_V1.jpg] <https://microsites.arri.com/stellar/>
>
> Get all the latest information from www.arri.com<https://www.arri.com/>, Facebook<https://www.facebook.com/TeamARRI>, Twitter<https://twitter.com/ARRIChannel>, Instagram<https://instagram.com/arri> and YouTube<https://www.youtube.com/user/ARRIChannel>.
>
> Arnold & Richter Cine Technik GmbH & Co. Betriebs KG
> Sitz: München - Registergericht: Amtsgericht München - Handelsregisternummer: HRA 57918
> Persönlich haftender Gesellschafter: Arnold & Richter Cine Technik GmbH
> Sitz: München - Registergericht: Amtsgericht München - Handelsregisternummer: HRB 54477
> Geschäftsführer: Dr. Michael Neuhäuser; Stephan Schenk; Walter Trauninger; Markus Zeiler
next prev parent reply other threads:[~2020-08-16 9:18 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-05 5:57 [PATCH v6 0/2] iio: light: Support AMS AS73211 digital XYZ sensor Christian Eggers
2020-08-05 5:57 ` [PATCH v6 1/2] dt-bindings: iio: light: add AMS AS73211 support Christian Eggers
2020-08-06 17:44 ` Jonathan Cameron
2020-08-05 5:57 ` [PATCH v6 2/2] iio: light: as73211: New driver Christian Eggers
2020-08-05 7:39 ` Andy Shevchenko
2020-08-06 17:44 ` Jonathan Cameron
2020-08-07 15:46 ` Christian Eggers
2020-08-08 16:14 ` Jonathan Cameron
2020-08-09 7:43 ` [PATCH] iio: documentation: light: Add as73211 sysfs documentation Christian Eggers
2020-08-09 11:30 ` Jonathan Cameron
2020-08-10 5:24 ` [PATCH v2] " Christian Eggers
2020-08-16 9:19 ` Jonathan Cameron
2020-08-10 9:00 ` [PATCH] " Pavel Machek
2020-08-10 9:57 ` Christian Eggers
2020-08-10 12:35 ` Pavel Machek
2020-08-10 13:24 ` Christian Eggers
2020-08-16 9:18 ` Jonathan Cameron [this message]
2020-09-01 18:46 ` [PATCH v6 2/2] iio: light: as73211: New driver Jonathan Cameron
2020-09-03 18:43 ` Jonathan Cameron
2020-09-09 18:05 ` Christian Eggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200816101844.79e1c5c5@archlinux \
--to=jic23@kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=andy.shevchenko@gmail.com \
--cc=ceggers@arri.de \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).