From: Jonathan Cameron <jic23@kernel.org>
To: Daniel Palmer <daniel@0x0f.com>
Cc: linux-iio@vger.kernel.org
Subject: Re: [RFC PATCH 2/2] iio: st-accel: Add support for Silan SC7A20 and SC7A30E
Date: Sun, 16 Aug 2020 10:40:09 +0100 [thread overview]
Message-ID: <20200816104009.76cb3870@archlinux> (raw)
In-Reply-To: <CAFr9PXkPXOef1rSKbHSEFdSJiogwQN2hdM+fdEpkcfTa93igvg@mail.gmail.com>
On Sun, 16 Aug 2020 18:27:03 +0900
Daniel Palmer <daniel@0x0f.com> wrote:
> Hi Jonathan,
>
> On Sun, 16 Aug 2020 at 17:52, Jonathan Cameron <jic23@kernel.org> wrote:
> > Same issue with sign off.
>
> I didn't think that was needed for an RFC. I'll add the sign off to the v1.
I'd always put them in anyway as RFCs sometimes get picked up if the
comments are all positive!
>
> > + Needs to be added to the device tree documentation in
> > Documentation/devicetree/bindings/iio/st-sensors.txt
>
> I'll add that in. Other than that was the change OK? I wasn't sure a
> massive copy/paste
> would be acceptable.
It's always a trade off with cases like this on whether we want to
add complexity to the code to handle different WAI values, or just
have a bit more constant data and replicate stuff.
I'm fine with the replicating options, but of course others may not be.
Jonathan
>
> Thanks,
>
> Daniel
next prev parent reply other threads:[~2020-08-16 9:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-11 13:48 [RFC PATCH 0/2] iio: st-accel: Add support for Silan clones Daniel Palmer
2020-08-11 13:48 ` [RFC PATCH 1/2] dt-bindings: vendor-prefixes: Add vendor prefix for Silan Daniel Palmer
2020-08-16 8:50 ` Jonathan Cameron
2020-08-11 13:48 ` [RFC PATCH 2/2] iio: st-accel: Add support for Silan SC7A20 and SC7A30E Daniel Palmer
2020-08-16 8:52 ` Jonathan Cameron
2020-08-16 9:27 ` Daniel Palmer
2020-08-16 9:40 ` Jonathan Cameron [this message]
2020-08-16 9:55 ` Andy Shevchenko
2020-08-16 11:59 ` Daniel Palmer
2020-08-19 18:19 ` Denis CIOCCA
2020-08-20 9:01 ` Jonathan Cameron
2020-08-20 9:17 ` Greg KH
2020-08-20 12:27 ` Daniel Palmer
2020-08-20 12:56 ` Andy Shevchenko
2020-08-20 12:34 ` Andy Shevchenko
2020-08-12 9:20 ` [RFC PATCH 0/2] iio: st-accel: Add support for Silan clones Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200816104009.76cb3870@archlinux \
--to=jic23@kernel.org \
--cc=daniel@0x0f.com \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox