From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A08BBC433E2 for ; Mon, 31 Aug 2020 10:17:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6170D2072D for ; Mon, 31 Aug 2020 10:17:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726112AbgHaKRf (ORCPT ); Mon, 31 Aug 2020 06:17:35 -0400 Received: from mga18.intel.com ([134.134.136.126]:10127 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726106AbgHaKRf (ORCPT ); Mon, 31 Aug 2020 06:17:35 -0400 IronPort-SDR: Wu3sGQ/Upvbg6GA4EF5UN2c1NhDp2F24+9/QQSFvbur8lH/lI5mokq/rqCparjmDOhlXvhAics Od5jpyFkbaMg== X-IronPort-AV: E=McAfee;i="6000,8403,9729"; a="144620496" X-IronPort-AV: E=Sophos;i="5.76,375,1592895600"; d="scan'208";a="144620496" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Aug 2020 03:17:34 -0700 IronPort-SDR: tFKIJfU1+Gs8rTKUROWweRktanRTMF2gKmOArNIZx0Xl4KUicM+sa2mLwB78N50N60p7O3HDiZ 1Q3gWHg/LC4w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,375,1592895600"; d="scan'208";a="330644173" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga008.jf.intel.com with ESMTP; 31 Aug 2020 03:17:33 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1kCgsU-00CyVW-Tn; Mon, 31 Aug 2020 13:17:30 +0300 Date: Mon, 31 Aug 2020 13:17:30 +0300 From: Andy Shevchenko To: Jonathan Cameron Cc: linux-iio , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler Subject: Re: [PATCH v1 5/8] iio: accel: bma220: Drop ACPI_PTR() and accompanying ifdeffery Message-ID: <20200831101730.GD1891694@smile.fi.intel.com> References: <20200831090813.78841-1-andriy.shevchenko@linux.intel.com> <20200831090813.78841-5-andriy.shevchenko@linux.intel.com> <20200831101908.52cb216e@archlinux> <20200831105504.2837cdb1@archlinux> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200831105504.2837cdb1@archlinux> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Mon, Aug 31, 2020 at 10:55:04AM +0100, Jonathan Cameron wrote: > On Mon, 31 Aug 2020 12:39:10 +0300 > Andy Shevchenko wrote: > > On Mon, Aug 31, 2020 at 12:19 PM Jonathan Cameron wrote: > > > On Mon, 31 Aug 2020 12:08:10 +0300 > > > Andy Shevchenko wrote: > > > > > > > The driver is quite likely used only on ACPI based platforms and > > > > rarely build with CONFIG_ACPI=n. Even though, the few dozens of bytes > > > > is better than ugly ifdeffery and inclusion of heavy header. > > > > > > Given this part is readily available on maker type break out boards > > > I doubt it is mostly ACPI. Rest of the comment is fine though. > > > > In-kernel use seems only ACPI (I grepped for pure SPI driver by name > > and didn't find anything). > > I hope we will have DT support for that as well (basically means > > adding OF ID table). > > > > Good to add the explicit DT support, but I think the nasty fallback is > still in place in which the old style ID table is used if we get a match > without manufacturer ID. > > So should be possible to instantiate it from DT even without the table. True, but as I said, there is no evidence that there is a single user in kernel. -- With Best Regards, Andy Shevchenko