* [PATCH] IIO: rockchip: add missing dependencies for saradc
@ 2020-09-01 20:40 Vicente Bergas
2020-09-06 15:20 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Vicente Bergas @ 2020-09-01 20:40 UTC (permalink / raw)
To: Jonathan Cameron, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald-Stadler, Heiko Stübner, linux-iio,
linux-rockchip
Cc: Vicente Bergas
This driver uses the triggered buffer functionality
but was not requiring it.
Signed-off-by: Vicente Bergas <vicencb@gmail.com>
---
drivers/iio/adc/Kconfig | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
index 66d9cc073157..cd90f60cdfd9 100644
--- a/drivers/iio/adc/Kconfig
+++ b/drivers/iio/adc/Kconfig
@@ -865,6 +865,9 @@ config ROCKCHIP_SARADC
tristate "Rockchip SARADC driver"
depends on ARCH_ROCKCHIP || (ARM && COMPILE_TEST)
depends on RESET_CONTROLLER
+ select IIO_BUFFER
+ select IIO_TRIGGER
+ select IIO_TRIGGERED_BUFFER
help
Say yes here to build support for the SARADC found in SoCs from
Rockchip.
--
2.28.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] IIO: rockchip: add missing dependencies for saradc
2020-09-01 20:40 [PATCH] IIO: rockchip: add missing dependencies for saradc Vicente Bergas
@ 2020-09-06 15:20 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2020-09-06 15:20 UTC (permalink / raw)
To: Vicente Bergas
Cc: Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald-Stadler,
Heiko Stübner, linux-iio, linux-rockchip
On Tue, 1 Sep 2020 22:40:54 +0200
Vicente Bergas <vicencb@gmail.com> wrote:
> This driver uses the triggered buffer functionality
> but was not requiring it.
>
> Signed-off-by: Vicente Bergas <vicencb@gmail.com>
Fix should now be in tree. I don't think the IIO_TRIGGER select
is necessary (and isn't in current fixed version) but if I'm wrong
on that please shout! Logically it shouldn't be required as the
driver doesn't provide a trigger, but we may have something missing
a stub somewhere.
Jonathan
> ---
> drivers/iio/adc/Kconfig | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> index 66d9cc073157..cd90f60cdfd9 100644
> --- a/drivers/iio/adc/Kconfig
> +++ b/drivers/iio/adc/Kconfig
> @@ -865,6 +865,9 @@ config ROCKCHIP_SARADC
> tristate "Rockchip SARADC driver"
> depends on ARCH_ROCKCHIP || (ARM && COMPILE_TEST)
> depends on RESET_CONTROLLER
> + select IIO_BUFFER
> + select IIO_TRIGGER
> + select IIO_TRIGGERED_BUFFER
> help
> Say yes here to build support for the SARADC found in SoCs from
> Rockchip.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-06 15:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-01 20:40 [PATCH] IIO: rockchip: add missing dependencies for saradc Vicente Bergas
2020-09-06 15:20 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).