Re: [PATCH v2 07/20] dt-bindings:iio:adc:nuvoton,nau7802 yaml conversion

Alexandre Belloni
2020-09-09T19:19:32Z

Hi,

On 09/09/2020 18:59:33+0100, Jonathan Cameron wrote:
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> A simple conversion from txt file to yaml. I added the #io-channel-cells
> property as optional to allow the channels of this ADCs to be used
> to provide services to other drivers, for example if an analog
> accelerometer is connected.
>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
> ---
> .../bindings/iio/adc/nuvoton,nau7802.yaml | 50 +++++++++++++++++++
> .../bindings/iio/adc/nuvoton-nau7802.txt | 18 -------
> 2 files changed, 50 insertions(+), 18 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/nuvoton,nau7802.yaml b/Documentation/devicetree/bindings/iio/adc/nuvoton,nau7802.yaml
> new file mode 100644
> index 000000000000..bcd041ea28a8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/nuvoton,nau7802.yaml
> @@ -0,0 +1,50 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/adc/nuvoton,nau7802.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Nuvoton NAU7802 I2c Analog to Digital Converter (ADC)
> +
> +maintainers:
> + - Alexandre Belloni <alexandre.belloni@free-electrons.com>
> + - Maxime Ripard <maxime.ripard@free-electrons.com>
> +

Sorry, I meant to reply earlier. Can you make that:

- Alexandre Belloni <alexandre.belloni@bootlin.com>
- Maxime Ripard <mripard@kernel.org>

Else, this seems good to me!

> +properties:
> + compatible:
> + const: nuvoton,nau7802
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + nuvoton,vldo:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description:
> + Internal reference voltage in millivolts to be configured.
> + minimum: 2400
> + maximum: 4500
> +
> + "#io-channel-cells":
> + const: 1
> +
> +required:
> + - compatible
> + - reg
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + nau7802@2a {
> + compatible = "nuvoton,nau7802";
> + reg = <0x2a>;
> + nuvoton,vldo = <3000>;
> + };
> + };
> +...
> diff --git a/Documentation/devicetree/bindings/iio/adc/nuvoton-nau7802.txt b/Documentation/devicetree/bindings/iio/adc/nuvoton-nau7802.txt
> deleted file mode 100644
> index e9582e6fe350..000000000000
> --- a/Documentation/devicetree/bindings/iio/adc/nuvoton-nau7802.txt
> +++ /dev/null
> @@ -1,18 +0,0 @@
> -* Nuvoton NAU7802 Analog to Digital Converter (ADC)
> -
> -Required properties:
> - - compatible: Should be "nuvoton,nau7802"
> - - reg: Should contain the ADC I2C address
> -
> -Optional properties:
> - - nuvoton,vldo: Internal reference voltage in millivolts to be
> - configured valid values are between 2400 mV and 4500 mV.
> - - interrupts: IRQ line for the ADC. If not used the driver will use
> - polling.
> -
> -Example:
> -adc2: nau7802@2a {
> - compatible = "nuvoton,nau7802";
> - reg = <0x2a>;
> - nuvoton,vldo = <3000>;
> -};
> --
> 2.28.0
>

--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering