Re: [PATCH v2 17/20] dt-bindings:iio:adc:holt,hi8435 yaml conversion

Rob Herring
2020-09-15T19:29:50Z

On Wed, Sep 09, 2020 at 06:59:43PM +0100, Jonathan Cameron wrote:
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> Very simple binding. I've changed the example to use the node
> name threshold-detector@0 as sensor@0 seemed too generic.
>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> ---
> .../devicetree/bindings/iio/adc/hi8435.txt | 21 --------
> .../bindings/iio/adc/holt,hi8435.yaml | 49 +++++++++++++++++++
> 2 files changed, 49 insertions(+), 21 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/hi8435.txt b/Documentation/devicetree/bindings/iio/adc/hi8435.txt
> deleted file mode 100644
> index 3b0348c5e516..000000000000
> --- a/Documentation/devicetree/bindings/iio/adc/hi8435.txt
> +++ /dev/null
> @@ -1,21 +0,0 @@
> -Holt Integrated Circuits HI-8435 threshold detector bindings
> -
> -Required properties:
> - - compatible: should be "holt,hi8435"
> - - reg: spi chip select number for the device
> -
> -Recommended properties:
> - - spi-max-frequency: definition as per
> - Documentation/devicetree/bindings/spi/spi-bus.txt
> -
> -Optional properties:
> - - gpios: GPIO used for controlling the reset pin
> -
> -Example:
> -sensor@0 {
> - compatible = "holt,hi8435";
> - reg = <0>;
> - gpios = <&gpio6 1 0>;
> -
> - spi-max-frequency = <1000000>;
> -};
> diff --git a/Documentation/devicetree/bindings/iio/adc/holt,hi8435.yaml b/Documentation/devicetree/bindings/iio/adc/holt,hi8435.yaml
> new file mode 100644
> index 000000000000..a35cf3876b86
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/holt,hi8435.yaml
> @@ -0,0 +1,49 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/adc/holt,hi8435.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Holt Integrated Circuits HI-8435 SPI threshold detector
> +
> +maintainers:
> + - Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> +
> +description: |
> + Datasheet: http://www.holtic.com/documents/427-hi-8435_v-rev-lpdf.do
> +
> +properties:
> + compatible:
> + const: holt,hi8435
> +
> + reg:
> + maxItems: 1
> +
> + gpios:
> + description:
> + GPIO used for controlling the reset pin

maxItems: 1

With that,

Reviewed-by: Rob Herring <robh@kernel.org>

> +
> + spi-max-frequency: true
> +
> + "#io-channel-cells":
> + const: 1
> +
> +required:
> + - compatible
> + - reg
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + spi {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + threshold-detector@0 {
> + compatible = "holt,hi8435";
> + reg = <0>;
> + gpios = <&gpio6 1 0>;
> + spi-max-frequency = <1000000>;
> + };
> + };
> +...
> --
> 2.28.0
>