Re: [PATCH] kernel-doc: add support for ____cacheline_aligned attribute

[Jonathan Corbet <corbet@lwn.net>]

On Thu, 10 Sep 2020 19:54:15 +0100
Jonathan Cameron <jic23@kernel.org> wrote:

> Subroutine dump_struct uses type attributes to check if the struct
> syntax is valid. Then, it removes all attributes before using it for
> output. `____cacheline_aligned` is an attribute that is
> not included in both steps. Add it, since it is used by kernel structs.
> 
> Based on previous patch to add ____cacheline_aligned_in_smp.
> Motivated by patches to reorder this attribute to before the
> variable name.   Whilst we could do that in all cases, that would
> be a massive change and it is more common in the kernel to place
> this particular attribute after the variable name. A quick grep
> suggests approximately 400 instances of which 341 have this
> attribute just before a semicolon and hence after the variable name.
> 
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc: Lee Jones <lee.jones@linaro.org>
> ---
> 
> Note I haven't figured out what this is actually doing and hence the
> patch is done by copying the changes made for ____cacheline_aligned_in_smp.
> It seems to work. :)

The little secret is that *nobody* really understands what all the regexes
in kernel-doc do :)  Anyway, it does indeed seem to work; applied, thanks.

jon