From: Jonathan Cameron <jic23@kernel.org>
To: Rob Herring <robh+dt@kernel.org>
Cc: "open list:IIO SUBSYSTEM AND DRIVERS" <linux-iio@vger.kernel.org>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Kevin Hilman <khilman@baylibre.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>
Subject: Re: [PATCH v3 1/1] dt-bindings:iio:adc:amlogic,meson-saradc yaml conversion
Date: Wed, 23 Sep 2020 21:07:19 +0100 [thread overview]
Message-ID: <20200923210719.456b940b@archlinux> (raw)
In-Reply-To: <CAL_Jsq+-2MA8ych91Ln_sY=VJQtU=muRk9ZtBcRqoTYEOY6ezA@mail.gmail.com>
On Tue, 22 Sep 2020 08:08:48 -0600
Rob Herring <robh+dt@kernel.org> wrote:
> On Sun, Sep 20, 2020 at 7:54 AM Jonathan Cameron <jic23@kernel.org> wrote:
> >
> > From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> >
> > This binding is non trivial due to the range of different parts
> > supported having several subtle quirks. Martin has helped
> > clarify some of them.
> >
> > Note, I haven't restricted the amlogic,hhi-sysctrl to only
> > be present on the relevant parts if nvmem stuff also is, but
> > it would seem to be rather odd if it were otherwise.
> >
> > Perhaps we look to make this binding more restrictive at a later date.
> >
> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> > Cc: Kevin Hilman <khilman@baylibre.com>
> > Cc: Neil Armstrong <narmstrong@baylibre.com>
> > Cc: Jerome Brunet <jbrunet@baylibre.com>
> >
> > ---
> > Changes since v2
> > (thanks Rob and Martin)
> > - consistent capitalization
> > - clock names etc all shared, only the number of them changed dependent
> > on type.
> > - missing maxItems for nvmem-cells.
> >
> > .../bindings/iio/adc/amlogic,meson-saradc.txt | 48 ------
> > .../iio/adc/amlogic,meson-saradc.yaml | 149 ++++++++++++++++++
> > 2 files changed, 149 insertions(+), 48 deletions(-)
>
> Reviewed-by: Rob Herring <robh@kernel.org>
Applied. Thanks,
Jonathan
next prev parent reply other threads:[~2020-09-23 20:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-20 13:54 [PATCH v3 0/1] dt-bindings:iio:adc: Another set of yaml conversions Jonathan Cameron
2020-09-20 13:54 ` [PATCH v3 1/1] dt-bindings:iio:adc:amlogic,meson-saradc yaml conversion Jonathan Cameron
2020-09-22 14:08 ` Rob Herring
2020-09-23 20:07 ` Jonathan Cameron [this message]
2020-09-24 13:02 ` Martin Blumenstingl
2020-09-25 11:43 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200923210719.456b940b@archlinux \
--to=jic23@kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-iio@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=narmstrong@baylibre.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).