From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51717C2D0A8 for ; Wed, 23 Sep 2020 20:52:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F199B2376E for ; Wed, 23 Sep 2020 20:52:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600894352; bh=Q06p8Et9US/NfgUeEtjZnh3mkPhqpZz0306QBf0WJPs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=1MJvlKr2w5zFg/TWLC1MMh5V78b5YVTG1vuRAuJTcpsmh35RlJhTtvgQfISU6Nq3x IwCzzBscpbWdNnEcLNFiHlN42d8zNtnpomirfh0EumLuyNTwwXRyh8tp2YQ/bzZdMn plHRvYqT3VWPZ57qC3Nd1hoKoG4rJgdNN9q01km4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726381AbgIWUwb (ORCPT ); Wed, 23 Sep 2020 16:52:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:40918 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726265AbgIWUwb (ORCPT ); Wed, 23 Sep 2020 16:52:31 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 331EC214F1; Wed, 23 Sep 2020 20:52:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600894350; bh=Q06p8Et9US/NfgUeEtjZnh3mkPhqpZz0306QBf0WJPs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=RM+T9ohJJqm2UxXudwE51CP564QadUXTGiUXONJqMn3Hc94O2xnXlDbroE6uOaHaz YqrzHaRhJEkPu1qY/5Wcn3TubfoxstyN/Btz2zdBN/K6SoDLKvtCV7jcuX5Fq+pnfB p/qsWoX5SraJZXlEC5GLvkb3vuOOYAa5VbgpCCe8= Date: Wed, 23 Sep 2020 21:52:25 +0100 From: Jonathan Cameron To: Wang ShaoBo Cc: , , , , , , Subject: Re: [PATCH -next] iio: adc: at91-sama5d2_adc: Use devm_platform_get_and_ioremap_resource() Message-ID: <20200923215158.1d3d73fc@archlinux> In-Reply-To: <20200918082837.32610-1-bobo.shaobowang@huawei.com> References: <20200918082837.32610-1-bobo.shaobowang@huawei.com> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Fri, 18 Sep 2020 16:28:37 +0800 Wang ShaoBo wrote: > Make use of devm_platform_get_and_ioremap_resource() provided by > driver core platform instead of duplicated analogue. > > Signed-off-by: Wang ShaoBo Hi, Thanks. As far as I can see this boilerplate removal with no side effects, so applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to poke at it. Thanks, Jonathan > --- > drivers/iio/adc/at91-sama5d2_adc.c | 10 +++------- > 1 file changed, 3 insertions(+), 7 deletions(-) > > diff --git a/drivers/iio/adc/at91-sama5d2_adc.c b/drivers/iio/adc/at91-sama5d2_adc.c > index de9583d6cddd..ad7d9819f83c 100644 > --- a/drivers/iio/adc/at91-sama5d2_adc.c > +++ b/drivers/iio/adc/at91-sama5d2_adc.c > @@ -1764,17 +1764,13 @@ static int at91_adc_probe(struct platform_device *pdev) > mutex_init(&st->lock); > INIT_WORK(&st->touch_st.workq, at91_adc_workq_handler); > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - if (!res) > - return -EINVAL; > + st->base = devm_platform_get_and_ioremap_resource(pdev, 0, &res); > + if (IS_ERR(st->base)) > + return PTR_ERR(st->base); > > /* if we plan to use DMA, we need the physical address of the regs */ > st->dma_st.phys_addr = res->start; > > - st->base = devm_ioremap_resource(&pdev->dev, res); > - if (IS_ERR(st->base)) > - return PTR_ERR(st->base); > - > st->irq = platform_get_irq(pdev, 0); > if (st->irq <= 0) { > if (!st->irq)