From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07F81C4727C for ; Tue, 29 Sep 2020 15:48:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ABA71206D9 for ; Tue, 29 Sep 2020 15:48:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601394499; bh=WW9lgDeN8iQFoq7lTXLFBgvRZng4yjecbQILCi4uOd0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=zBoRKTvFuKQmkLmJSzM3i3uRZsMr0MfjFacKPlZ98XxBRjYJM+I9LOx04MUIHC8/0 q8Y4Mk0gew9IzMAYadWyFDY02Uy+g48YeNOY+lso1qRtlbpUkepCHXndEIrLJGDsIV RlT5PoGHm3vnf2kyDvrtmWgHeM/6kw3jovQZooQY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729012AbgI2PsT (ORCPT ); Tue, 29 Sep 2020 11:48:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:40260 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725497AbgI2PsT (ORCPT ); Tue, 29 Sep 2020 11:48:19 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 00729206D9; Tue, 29 Sep 2020 15:48:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601394498; bh=WW9lgDeN8iQFoq7lTXLFBgvRZng4yjecbQILCi4uOd0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=NIno9hhau8LsyYnfVKhWqYr7gfl/Yh8wBMCWreIxuqNk0Yj207B4DQ1tb3FFgcxMt qGz50qnVmVUWGEVAOStcyHD42XhDl8ci5cIwSZfyGfRFRw7/Ce2EOqDm3bBQaGy5fm KpFnzsWuDAUaiIG9H/jxJbf8i2Y1n9tRgrkbl1zs= Date: Tue, 29 Sep 2020 16:48:13 +0100 From: Jonathan Cameron To: Cristian Pop Cc: , , Rob Herring , devicetree@vger.kernel.org Subject: Re: [PATCH v7 5/5] dt-bindings:iio:adc:adc.txt: Add documentation for channel label attribute Message-ID: <20200929164813.2a9bfcf7@archlinux> In-Reply-To: <20200928090959.88842-5-cristian.pop@analog.com> References: <20200928090959.88842-1-cristian.pop@analog.com> <20200928090959.88842-5-cristian.pop@analog.com> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Mon, 28 Sep 2020 12:09:59 +0300 Cristian Pop wrote: > Optional attribute for better identification of the channels. > > Signed-off-by: Cristian Pop This one is on my list of binding files to convert fairly soon so I'm fine with this going in whilst it's still in txt form. The addition of reg here shows up a quirk of this binding. We originally introduced it to specify differential pairs, hence the @ can refer to the first value of diff-channels instead of reg. Hopefully I'll remember to clarify that when doing the yaml conversion. The series looks good to me, but given timing it won't make the merge window for the coming cycle. +CC Rob and the dt list. > --- > Changes in v7: > - Add this extra commit > Documentation/devicetree/bindings/iio/adc/adc.txt | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/iio/adc/adc.txt b/Documentation/devicetree/bindings/iio/adc/adc.txt > index 5bbaa330a250..4b37575bbddc 100644 > --- a/Documentation/devicetree/bindings/iio/adc/adc.txt > +++ b/Documentation/devicetree/bindings/iio/adc/adc.txt > @@ -5,18 +5,24 @@ Optional properties for child nodes: > - diff-channels : Differential channels muxed for this ADC. The first value > specifies the positive input pin, the second value the negative > input pin. > +- reg: The channel number. > +- label: Unique name to identify which channel this is. > > Example: > adc@0 { > compatible = "some,adc"; > ... > channel@0 { > + reg = <0>; > + label = "channel_0_name"; > bipolar; > diff-channels = <0 1>; > ... > }; > > channel@1 { > + reg = <1>; > + label = "channel_1_name"; > diff-channels = <2 3>; > ... > };