linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Alexandru Ardelean <alexandru.ardelean@analog.com>
Cc: <linux-kernel@vger.kernel.org>, <linux-iio@vger.kernel.org>
Subject: Re: [PATCH] iio: dac: ad7303: remove platform data header
Date: Sat, 10 Oct 2020 18:04:00 +0100	[thread overview]
Message-ID: <20201010180400.09658b3c@archlinux> (raw)
In-Reply-To: <20201001141004.53846-1-alexandru.ardelean@analog.com>

On Thu, 1 Oct 2020 17:10:04 +0300
Alexandru Ardelean <alexandru.ardelean@analog.com> wrote:

> The information in the ad7303 platform_data header is unused, so it's dead
> code.
> This change removes it and it's inclusion from the driver.
> 
> Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
Applied.

Thanks,

Jonathan
> ---
>  drivers/iio/dac/ad7303.c             |  2 --
>  include/linux/platform_data/ad7303.h | 20 --------------------
>  2 files changed, 22 deletions(-)
>  delete mode 100644 include/linux/platform_data/ad7303.h
> 
> diff --git a/drivers/iio/dac/ad7303.c b/drivers/iio/dac/ad7303.c
> index 2e46def9d8ee..dbb4645ab6b1 100644
> --- a/drivers/iio/dac/ad7303.c
> +++ b/drivers/iio/dac/ad7303.c
> @@ -17,8 +17,6 @@
>  #include <linux/iio/iio.h>
>  #include <linux/iio/sysfs.h>
>  
> -#include <linux/platform_data/ad7303.h>
> -
>  #define AD7303_CFG_EXTERNAL_VREF BIT(15)
>  #define AD7303_CFG_POWER_DOWN(ch) BIT(11 + (ch))
>  #define AD7303_CFG_ADDR_OFFSET	10
> diff --git a/include/linux/platform_data/ad7303.h b/include/linux/platform_data/ad7303.h
> deleted file mode 100644
> index c2bd0a13bea1..000000000000
> --- a/include/linux/platform_data/ad7303.h
> +++ /dev/null
> @@ -1,20 +0,0 @@
> -/* SPDX-License-Identifier: GPL-2.0-only */
> -/*
> - * Analog Devices AD7303 DAC driver
> - *
> - * Copyright 2013 Analog Devices Inc.
> - */
> -
> -#ifndef __IIO_ADC_AD7303_H__
> -#define __IIO_ADC_AD7303_H__
> -
> -/**
> - * struct ad7303_platform_data - AD7303 platform data
> - * @use_external_ref: If set to true use an external voltage reference connected
> - * to the REF pin, otherwise use the internal reference derived from Vdd.
> - */
> -struct ad7303_platform_data {
> -	bool use_external_ref;
> -};
> -
> -#endif


      reply	other threads:[~2020-10-10 23:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-01 14:10 [PATCH] iio: dac: ad7303: remove platform data header Alexandru Ardelean
2020-10-10 17:04 ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201010180400.09658b3c@archlinux \
    --to=jic23@kernel.org \
    --cc=alexandru.ardelean@analog.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).