[PATCH] staging: iio: adis16240: add blank line before struct definition

[PATCH] staging: iio: adis16240: add blank line before struct definition

[Deepak R Varma]

Add a blank line before starting structure definition as per coding
style guidelines. Issue reported by checkpatch script.

Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>
---
 drivers/staging/iio/accel/adis16240.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/iio/accel/adis16240.c b/drivers/staging/iio/accel/adis16240.c
index 5064adce5f58..8d3afc6dc755 100644
--- a/drivers/staging/iio/accel/adis16240.c
+++ b/drivers/staging/iio/accel/adis16240.c
@@ -426,6 +426,7 @@ static int adis16240_probe(struct spi_device *spi)
 
 	return devm_iio_device_register(&spi->dev, indio_dev);
 }
+
 static const struct of_device_id adis16240_of_match[] = {
 	{ .compatible = "adi,adis16240" },
 	{ },
-- 
2.25.1

Re: [Outreachy kernel] [PATCH] staging: iio: adis16240: add blank line before struct definition

[Julia Lawall]

On Sun, 11 Oct 2020, Deepak R Varma wrote:

> Add a blank line before starting structure definition as per coding
> style guidelines. Issue reported by checkpatch script.
>
> Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>

Acked-by: Julia Lawall <julia.lawall@inria.fr>

> ---
>  drivers/staging/iio/accel/adis16240.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/iio/accel/adis16240.c b/drivers/staging/iio/accel/adis16240.c
> index 5064adce5f58..8d3afc6dc755 100644
> --- a/drivers/staging/iio/accel/adis16240.c
> +++ b/drivers/staging/iio/accel/adis16240.c
> @@ -426,6 +426,7 @@ static int adis16240_probe(struct spi_device *spi)
>
>  	return devm_iio_device_register(&spi->dev, indio_dev);
>  }
> +
>  static const struct of_device_id adis16240_of_match[] = {
>  	{ .compatible = "adi,adis16240" },
>  	{ },
> --
> 2.25.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20201011104800.GA29412%40ubuntu204.
>

Re: [Outreachy kernel] [PATCH] staging: iio: adis16240: add blank line before struct definition

[Jonathan Cameron]

On Sun, 11 Oct 2020 13:06:06 +0200 (CEST)
Julia Lawall <julia.lawall@inria.fr> wrote:

> On Sun, 11 Oct 2020, Deepak R Varma wrote:
> 
> > Add a blank line before starting structure definition as per coding
> > style guidelines. Issue reported by checkpatch script.
> >
> > Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com>  
> 
> Acked-by: Julia Lawall <julia.lawall@inria.fr>

Hi Deepak / Julia.

Applied to the togreg branch of iio.git.  Initially I'll be pushing that
out as testing, so that various systems that run build tests can check
we haven't missed anything.   Clearly they won't be finding anything in
this particular patch, but there are other things in that branch that
may be more problematic.

Given timing wrt to the merge window, these won't go upstream until
next cycle.  I will probably send Greg KH a pull request in a few
weeks time (after rc1) including this patch.

Thanks,

Jonathan


> 
> > ---
> >  drivers/staging/iio/accel/adis16240.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/staging/iio/accel/adis16240.c b/drivers/staging/iio/accel/adis16240.c
> > index 5064adce5f58..8d3afc6dc755 100644
> > --- a/drivers/staging/iio/accel/adis16240.c
> > +++ b/drivers/staging/iio/accel/adis16240.c
> > @@ -426,6 +426,7 @@ static int adis16240_probe(struct spi_device *spi)
> >
> >  	return devm_iio_device_register(&spi->dev, indio_dev);
> >  }
> > +
> >  static const struct of_device_id adis16240_of_match[] = {
> >  	{ .compatible = "adi,adis16240" },
> >  	{ },
> > --
> > 2.25.1
> >
> > --
> > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20201011104800.GA29412%40ubuntu204.
> >