From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E081C2D0A3 for ; Mon, 2 Nov 2020 11:37:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 110D82071E for ; Mon, 2 Nov 2020 11:37:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="KSYv2SBj" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728534AbgKBLha (ORCPT ); Mon, 2 Nov 2020 06:37:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50140 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728414AbgKBLh1 (ORCPT ); Mon, 2 Nov 2020 06:37:27 -0500 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 20C81C0617A6 for ; Mon, 2 Nov 2020 03:37:27 -0800 (PST) Received: by mail-wr1-x441.google.com with SMTP id n15so14228048wrq.2 for ; Mon, 02 Nov 2020 03:37:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=8UEl3atZi8MUx6nvj42rdC/d5FIT8bNul3drA5C9t4o=; b=KSYv2SBjH+Ws6ZE66cEijT7O/44A/LCuajSE2vHr3jGkSmXaqHmm551LnfxdPt/sox 4WLB14qmWWkWjgQoPRM+KdQBXy4zne/f7s0fSNe7h9Y7eFxTw1mTAxU+fkrOfUF0eZRo DXw/GDr+NZ48tXPOWLDAfCVCkXJt2gEHbBTfVHRwwOD086BLpQQQ99l8x4iY58INvbFO RrCEagxAxMGLY//E9t2Zf4l52Jsgn0IeZbcpqn3aw8b7x8B4CONDhHmSs1DVKtwyMb7j 5UVXbbH5S869WvmO53EAt6yz0SpUMrv2foIYNqJsOZARN8Dg6wW5+n0nYJ4aSTPCe5dn R2tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=8UEl3atZi8MUx6nvj42rdC/d5FIT8bNul3drA5C9t4o=; b=DzHUUiEz0OSgG3Q3CtQQTPVQznaaV/rBMN9wHfj3VxGedaCFNlBlsGI+3dTuI0xuw5 JAVo3tQ5Ft6WIcr1abNwxdZIy4cd7lWcD0kVPvmiotyfn2qF1NF4zkKLRAestD7nwlZI EZqY7V5Vve24ZCHT2fiOifFFx8JzD5TbmmDyvvH/F4ZYNnTv2dr6X4xcOChkORwXt2YN 3E92TfK6DFqX4Ry3Be150umC8ql3bI+TNpRjhU5SvMinPYeuxTYfCeH2cV0by/VL0h/q r3AMT/v5TPS1S0gUL2x04LKtXqFYazbrwpSOArEusKCKmsRGdud/4hgBBBe0BGTf6e6N xTyA== X-Gm-Message-State: AOAM532BuUMOuNE+OnpYZQaabIi1A3WuChrdL2yqHXqXubFLEz2f4iYE zk3uanRxGxkUluMdpZ+XpV9guQ== X-Google-Smtp-Source: ABdhPJwjpHDRKbBPhhmiy3PdY5LEErVkz2mLP78hjliMe/KtqpvD4IG+8gVlI4H1k7GeLJtxo6TD4Q== X-Received: by 2002:adf:9184:: with SMTP id 4mr19795099wri.258.1604317045878; Mon, 02 Nov 2020 03:37:25 -0800 (PST) Received: from dell ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id i2sm6628290wmc.28.2020.11.02.03.37.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 03:37:25 -0800 (PST) Date: Mon, 2 Nov 2020 11:37:23 +0000 From: Lee Jones To: Lars-Peter Clausen Cc: jic23@kernel.org, pmeerw@pmeerw.net, linux-iio@vger.kernel.org Subject: Re: [PATCH 1/1] iio: industrialio-trigger: Use 'gnu_printf' format notation Message-ID: <20201102113723.GM4127@dell> References: <20201102111725.1048562-1-lee.jones@linaro.org> <6b5807c1-08af-2633-3352-bd7ae084cbe2@metafoo.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <6b5807c1-08af-2633-3352-bd7ae084cbe2@metafoo.de> Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Mon, 02 Nov 2020, Lars-Peter Clausen wrote: > On 11/2/20 12:17 PM, Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > > > drivers/iio/industrialio-trigger.c: In function ‘iio_alloc_pollfunc’: > > drivers/iio/industrialio-trigger.c:338:2: warning: function ‘iio_alloc_pollfunc’ might be a candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format] > > Jonathan already sent a similar patch. See > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=cd7798cbd28044a3026619e36993160ba8fa118d > So adding this to the prototype also squashes the warning? > > Signed-off-by: Lee Jones > > --- > > drivers/iio/industrialio-trigger.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/iio/industrialio-trigger.c b/drivers/iio/industrialio-trigger.c > > index 583bb51f65a75..1d65c83439d84 100644 > > --- a/drivers/iio/industrialio-trigger.c > > +++ b/drivers/iio/industrialio-trigger.c > > @@ -320,6 +320,7 @@ irqreturn_t iio_pollfunc_store_time(int irq, void *p) > > } > > EXPORT_SYMBOL(iio_pollfunc_store_time); > > +__printf(5, 6) > > struct iio_poll_func > > *iio_alloc_pollfunc(irqreturn_t (*h)(int irq, void *p), > > irqreturn_t (*thread)(int irq, void *p), > > -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog