From: Jonathan Cameron <jic23@kernel.org>
To: Alexandru Ardelean <alexandru.ardelean@analog.com>
Cc: <linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] iio: accel: adis16209: remove unneeded spi_set_drvdata()
Date: Sat, 21 Nov 2020 15:40:29 +0000 [thread overview]
Message-ID: <20201121154029.3950c659@archlinux> (raw)
In-Reply-To: <20201119141806.84827-1-alexandru.ardelean@analog.com>
On Thu, 19 Nov 2020 16:18:06 +0200
Alexandru Ardelean <alexandru.ardelean@analog.com> wrote:
> There is no matching spi_get_drvdata() in the driver. This looks like a
> left-over from before the driver was converted to device-managed functions.
>
> Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
Applied
> ---
> drivers/iio/accel/adis16209.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/iio/accel/adis16209.c b/drivers/iio/accel/adis16209.c
> index 4a841aec6268..6c2d4a967de7 100644
> --- a/drivers/iio/accel/adis16209.c
> +++ b/drivers/iio/accel/adis16209.c
> @@ -279,7 +279,6 @@ static int adis16209_probe(struct spi_device *spi)
> return -ENOMEM;
>
> st = iio_priv(indio_dev);
> - spi_set_drvdata(spi, indio_dev);
>
> indio_dev->name = spi->dev.driver->name;
> indio_dev->info = &adis16209_info;
prev parent reply other threads:[~2020-11-21 15:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-19 14:18 [PATCH] iio: accel: adis16209: remove unneeded spi_set_drvdata() Alexandru Ardelean
2020-11-21 15:40 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201121154029.3950c659@archlinux \
--to=jic23@kernel.org \
--cc=alexandru.ardelean@analog.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).