From: Jonathan Cameron <jic23@kernel.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Jeremy Cline <jeremy@jcline.org>,
linux-iio <linux-iio@vger.kernel.org>
Subject: Re: [PATCH 1/3] iio: accel: bmc150: Improve ACPI enumeration support
Date: Sat, 28 Nov 2020 13:16:04 +0000 [thread overview]
Message-ID: <20201128131604.1367126b@archlinux> (raw)
In-Reply-To: <ec8c6e1e-f914-9ee7-133f-2f55d7cc8dfb@redhat.com>
On Wed, 25 Nov 2020 11:49:15 +0100
Hans de Goede <hdegoede@redhat.com> wrote:
> Hi,
>
> On 11/25/20 11:41 AM, Andy Shevchenko wrote:
> > On Wed, Nov 25, 2020 at 10:37 AM Hans de Goede <hdegoede@redhat.com> wrote:
> >>
> >> Hi All,
> >>
> >> This series improves support for ACPI enumeration of bmc150 accels
> >> described by an ACPI node with an ACPI hw-id of BOSC0200:
> >>
> >> 1. Add support for nodes which describe 2 acceleromers in a single node,
> >
> > accelerometers
> >
> >> fixing: https://bugzilla.kernel.org/show_bug.cgi?id=198671
> >>
> >> 2. Add support for reading the mount-matrix from the ACPI node.
> >>
> >> This is done in patches 2 - 3, patch 1 is a trivial cleanup which I noticed
> >> could be done while working on this.
> >>
> >> Patch 2 is based on an earlier patch for this from Jeremy Cline:
> >> https://lore.kernel.org/r/010001602cf53153-39ad69f1-1b39-4e6d-a748-9455a16c2fbd-000000@email.amazonses.com
> >>
> >> That patch was put on hold because normally ACPI nodes which describe
> >> multiple i2c-clients in a single node are handled by:
> >> drivers/platform/x86/i2c-multi-instantiate.c
> >>
> >> Which I tried to do at first, but as explained in the commit msg
> >> of the updated patch, that is not possible in this special case
> >> (because it would cause userspace breakage due to the modalias changing).
> >
> > This is marked as patch 1?!
>
> Yes my bad, sorry.
>
> > Usually --cover-letter produces a correct template...
>
> I use --compose, time to switch to --cover-letter instead I guess.
>
> Regards,
>
> Hans
>
Other than the minor bits Andy mentioned I'm fine with this.
It does sort of feel like we should be gathering documentation somewhere of
where this crazy stuff has been seen in the wild.
Oh for a standard... Whilst I've been known to push the odd thing through
standards bodies, I'm not sure I can really claim this one is related to my
day job (Huawei is a UEFI forum member). If anyone is particularly
enthusiastic and doesn't have direct access to the UEFI forum via their
job, they could try using the code first route into ACPI via tianocore.
Of course, nothing says anyone will actually use the standard anyway but
at least it would give us the moral high ground ;)
Jonathan
next prev parent reply other threads:[~2020-11-28 22:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-25 8:36 [PATCH 1/3] iio: accel: bmc150: Improve ACPI enumeration support Hans de Goede
2020-11-25 8:36 ` [PATCH 1/3] iio: accel: bmc150: Removed unused bmc150_accel_dat irq member Hans de Goede
2020-11-25 8:36 ` [PATCH 2/3] iio: accel: bmc150: Check for a second ACPI device for BOSC0200 Hans de Goede
2020-11-25 10:55 ` Andy Shevchenko
2020-11-25 11:11 ` Hans de Goede
2020-11-25 11:20 ` Andy Shevchenko
2020-11-25 16:09 ` Hans de Goede
2020-11-25 16:34 ` Andy Shevchenko
2020-11-25 8:36 ` [PATCH 3/3] iio: accel: bmc150: Get mount-matrix from ACPI Hans de Goede
2020-11-25 11:07 ` Andy Shevchenko
2020-11-25 11:12 ` Hans de Goede
2020-11-25 11:21 ` Andy Shevchenko
2020-11-25 10:41 ` [PATCH 1/3] iio: accel: bmc150: Improve ACPI enumeration support Andy Shevchenko
2020-11-25 10:49 ` Hans de Goede
2020-11-28 13:16 ` Jonathan Cameron [this message]
2020-11-28 13:32 ` Hans de Goede
2020-11-28 13:46 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201128131604.1367126b@archlinux \
--to=jic23@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=hdegoede@redhat.com \
--cc=jeremy@jcline.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).