From: Jonathan Cameron <jic23@kernel.org>
To: Michal Simek <michal.simek@xilinx.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
linux-iio@vger.kernel.org,
Anand Ashok Dumbre <anand.ashok.dumbre@xilinx.com>
Subject: Re: [PATCH 2/2] iio: xilinx-xadc: Add basic support for Ultrascale System Monitor
Date: Sun, 29 Nov 2020 13:14:41 +0000 [thread overview]
Message-ID: <20201129131441.3e9d83f8@archlinux> (raw)
In-Reply-To: <fb8db604-0ae3-1736-67bf-20a1dc8bc008@xilinx.com>
On Thu, 24 Sep 2020 08:08:31 +0200
Michal Simek <michal.simek@xilinx.com> wrote:
> Hi, +Anand,
>
> On 23. 09. 20 22:47, Jonathan Cameron wrote:
> > On Tue, 22 Sep 2020 15:46:24 +0200
> > Lars-Peter Clausen <lars@metafoo.de> wrote:
> >
> >> The xilinx-xadc IIO driver currently has support for the XADC in the Xilinx
> >> 7 series FPGAs. The system-monitor is the equivalent to the XADC in the
> >> Xilinx UltraScale and UltraScale+ FPGAs.
> >>
> >> The IP designers did a good job at maintaining backwards compatibility and
> >> only minor changes are required to add basic support for the system-monitor
> >> core.
> >>
> >> The non backwards compatible changes are:
> >> * Register map offset was moved from 0x200 to 0x400
> >> * Only one ADC compared to two in the XADC
> >> * 10 bit ADC instead of 12 bit ADC
> >> * Two of the channels monitor different supplies
> >>
> >> Add the necessary logic to accommodate these changes to support the
> >> system-monitor in the XADC driver.
> >>
> >> Note that this patch does not include support for some new features found
> >> in the system-monitor like additional alarms, user supply monitoring and
> >> secondary system-monitor access. This might be added at a later time.
> >>
> >> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
> >
> > Very nice. Will let this sit on the mailing list a bit longer
> > but looks good to me.
>
> FYI: I have asked Anand to take a look at it and retest.
>
> Thanks,
> Michal
>
Hi Michal / Anand,
Any feedback on this one?
Thanks
Jonathan
p.s. I'm just ploughing through my older emails and had this one marked
as waiting for a reply.
next prev parent reply other threads:[~2020-11-29 13:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-22 13:46 [PATCH 1/2] devicetree: Add Xilinx System Management Wizard binding documentation Lars-Peter Clausen
2020-09-22 13:46 ` [PATCH 2/2] iio: xilinx-xadc: Add basic support for Ultrascale System Monitor Lars-Peter Clausen
2020-09-23 20:47 ` Jonathan Cameron
2020-09-24 6:08 ` Michal Simek
2020-11-29 13:14 ` Jonathan Cameron [this message]
2020-11-30 8:47 ` Anand Ashok Dumbre
2020-12-11 9:57 ` Anand Ashok Dumbre
2020-12-13 11:57 ` Jonathan Cameron
2020-12-15 15:49 ` Lars-Peter Clausen
2020-12-15 18:28 ` Jonathan Cameron
2020-12-16 11:50 ` Lars-Peter Clausen
2020-12-13 12:03 ` [PATCH 1/2] devicetree: Add Xilinx System Management Wizard binding documentation Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201129131441.3e9d83f8@archlinux \
--to=jic23@kernel.org \
--cc=anand.ashok.dumbre@xilinx.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).