Re: [PATCH 2/2] iio: xilinx-xadc: Add basic support for Ultrascale System Monitor

[Jonathan Cameron <jic23@kernel.org>]

On Fri, 11 Dec 2020 09:57:30 +0000
Anand Ashok Dumbre <ANANDASH@xilinx.com> wrote:

> > -----Original Message-----
> > From: Jonathan Cameron <jic23@kernel.org>
> > Sent: Sunday 29 November 2020 1:15 PM
> > To: Michal Simek <michals@xilinx.com>
> > Cc: Lars-Peter Clausen <lars@metafoo.de>; Peter Meerwald-Stadler
> > <pmeerw@pmeerw.net>; linux-iio@vger.kernel.org; Anand Ashok Dumbre
> > <ANANDASH@xilinx.com>
> > Subject: Re: [PATCH 2/2] iio: xilinx-xadc: Add basic support for Ultrascale
> > System Monitor
> > 
> > On Thu, 24 Sep 2020 08:08:31 +0200
> > Michal Simek <michal.simek@xilinx.com> wrote:
> >   
> > > Hi, +Anand,
> > >
> > > On 23. 09. 20 22:47, Jonathan Cameron wrote:  
> > > > On Tue, 22 Sep 2020 15:46:24 +0200
> > > > Lars-Peter Clausen <lars@metafoo.de> wrote:
> > > >  
> > > >> The xilinx-xadc IIO driver currently has support for the XADC in
> > > >> the Xilinx
> > > >> 7 series FPGAs. The system-monitor is the equivalent to the XADC in
> > > >> the Xilinx UltraScale and UltraScale+ FPGAs.
> > > >>
> > > >> The IP designers did a good job at maintaining backwards
> > > >> compatibility and only minor changes are required to add basic
> > > >> support for the system-monitor core.
> > > >>
> > > >> The non backwards compatible changes are:
> > > >>   * Register map offset was moved from 0x200 to 0x400
> > > >>   * Only one ADC compared to two in the XADC
> > > >>   * 10 bit ADC instead of 12 bit ADC
> > > >>   * Two of the channels monitor different supplies
> > > >>
> > > >> Add the necessary logic to accommodate these changes to support the
> > > >> system-monitor in the XADC driver.
> > > >>
> > > >> Note that this patch does not include support for some new features
> > > >> found in the system-monitor like additional alarms, user supply
> > > >> monitoring and secondary system-monitor access. This might be added  
> > at a later time.  
> > > >>
> > > >> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>  
> > > >
> > > > Very nice.  Will let this sit on the mailing list a bit longer but
> > > > looks good to me.  
> > >
> > > FYI: I have asked Anand to take a look at it and retest.
> > >
> > > Thanks,
> > > Michal
> > >  
> > Hi Michal / Anand,
> > 
> > Any feedback on this one?
> > 
> > Thanks
> > 
> > Jonathan
> > 
> > p.s. I'm just ploughing through my older emails and had this one marked as
> > waiting for a reply.
> >   
> Hi Jonathan,
> 
> Thanks for waiting.
> The patch looks good.
> 
> Reviewed-by: Anand Ashok Dumbre <anandash@xilinx.com>
> Tested-by: Anand Ashok Dumbre <anandash@xilinx.com>

Thanks. I've applied this but there was a bit of complexity around
devm changes that went in whilst this was under review.

I think I fixed it up correctly, but great if you can take
a quick look to make sure I didn't mess it up.
I'll try and put the other outstanding series in as well which
will probably result in more fiddly corners during the merge.

Applied to the togreg branch of iio.git and pushed out as testing
or the autobuilders to see what we missed.

Thanks,

Jonathan

>