Re: [PATCH 0/1] iio: core: Copy iio_info.attrs->is_visible into iio_dev_opaque.chan_attr_group.is_visible

[Jonathan Cameron <jic23@kernel.org>]

On Sat, 5 Dec 2020 17:50:02 +0200
Alexandru Ardelean <ardeleanalex@gmail.com> wrote:

> On Sat, Dec 5, 2020 at 5:44 PM Hans de Goede <hdegoede@redhat.com> wrote:
> >
> > Hi,
> >
> > n 12/5/20 4:23 PM, Jonathan Cameron wrote:  
> > > On Tue, 1 Dec 2020 13:28:47 +0100
> > > Hans de Goede <hdegoede@redhat.com> wrote:
> > >  
> > >> Hi,
> > >>
> > >> On 11/25/20 9:46 AM, Hans de Goede wrote:  
> > >>> Hi All,
> > >>>
> > >>> I wrote this because I was planning on using is_visible in a driver's
> > >>> attribute group myself (1). But in the end it looks like I'm going to
> > >>> do things differently.
> > >>>
> > >>> This is still useful to have though, both for possible future use of
> > >>> is_visible in driver's attribute groups as well as to make the current
> > >>> usage of is_visible in adi-axi-adc.c actually work.  
> > >>
> > >> Jonathan, any opinion / remarks on this one?
> > >>
> > >> FWIW since I no longer have plans to use is_visible in an iio-driver
> > >> myself I'm fine with dropping this one, but:
> > >>
> > >> 1. Being able to use is_visible in the attr group of iio-drivers
> > >> seems like a nice thing to have.
> > >>
> > >> 2. There is an existing use of is_visible in adi-axi-adc.c which currently is broken.  
> > >
> > > I was giving time for Alex, or others to sanity check the need for a fix
> > > (well more specifically wether this one was the right one as clearly
> > > a need!).
> > >
> > > Anyhow, all sounds good.  Giving timing I'll mark it as one I'll pick up
> > > to go in after rc1 + stable.
> > >
> > > I'm not totally sure on the fixes tag.  Current patch will have to go on top
> > > of 207c2d27a010 ("iio: core: move channel list & group to private iio device object")
> > > but I don't think it worked before that either as we were still copying attributes
> > > around, just to a different location.  
> >
> > I don't think it is important for this one to go to the stables series,
> > so if you think it may cause problems feel free to drop the Fixes tag
> > (or point it to a different commit).  
> 
> I am also fine to not port this into the stable series.
> The AXI ADC driver that is usually used, is from the Analog Devices Linux tree.
> The current upstream version will be the one that reworks/cleans-up
> the old ones in the ADI tree.
> For some reason, there are like 4 AXI ADC variants in the ADI tree :p
> All these 4 should be unified into this one at some point.
Applied to the togreg branch of iio.git and pushed out as testing.

Thanks,

Jonathan

> 
> >
> > Regards,
> >
> > Hans
> >