From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB99CC433E0 for ; Tue, 29 Dec 2020 17:41:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9651620825 for ; Tue, 29 Dec 2020 17:41:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726263AbgL2RlP (ORCPT ); Tue, 29 Dec 2020 12:41:15 -0500 Received: from mail.kernel.org ([198.145.29.99]:54686 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726264AbgL2RlO (ORCPT ); Tue, 29 Dec 2020 12:41:14 -0500 Received: from archlinux (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0D2E620825; Tue, 29 Dec 2020 17:40:32 +0000 (UTC) Date: Tue, 29 Dec 2020 17:40:29 +0000 From: Jonathan Cameron To: Gwendal Grignou Cc: lars@metafoo.de, andy.shevchenko@gmail.com, ardeleanalex@gmail.com, linux-iio@vger.kernel.org Subject: Re: [PATCH v2 0/8] iio: Set default trigger device parent Message-ID: <20201229174029.5f59c8a8@archlinux> In-Reply-To: <20201216042009.15233-1-gwendal@chromium.org> References: <20201216042009.15233-1-gwendal@chromium.org> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Tue, 15 Dec 2020 20:20:08 -0800 Gwendal Grignou wrote: > [Added a new patch to rename iio_trigger_alloc argument from dev to > parent for clarity. Other patches remain the same.] > > Each drivers are setting trig->dev.parent to a common value - usually. > Move that in boiler plate code. > > The first patch set the parent pointer, the next is an automatic change > with spatch. > The remaining ones are straightforward manual changes. I'm not sure if it was deliberate, but I only got the cover letter and patch 8. Given automated tooling (b4) isn't going to cope with that I had a go at manually picking the other patches but ran into some issues. Please rebase the lot against the testing branch of iio.git Thanks, Jonathan > > Few drivers remain: > drivers/iio/adc/at91-sama5d2_adc.c > drivers/iio/adc/mxs-lradc-adc.c > trigger parent set to iio device instead of its parent. > > drivers/iio/adc/dln2-adc.c > trigger parent not set. > > drivers/iio/gyro/mpu3050-core.c > trigger allocated for iio device but parent set to iio device parent. > > drivers/iio/imu/bmi160/bmi160_core.c > drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c > trigger allocated for iio device but parent set to mapped register device holder. Looks like iio device parent. > > drivers/iio/trigger/stm32-lptimer-trigger.c > drivers/iio/trigger/stm32-timer-trigger.c > trigger allocated for device, but parent set to device parent. > > Gwendal Grignou (8): > iio: set default trig->dev.parent > iio: fix devm_iio_trigger_alloc with parent.cocci > iio: adis_trigger: Remove code to set trigger parent > iio: gp2ap020a00f: Remove code to set trigger parent > iio: lmp91000: Remove code to set trigger parent > iio: chemical: atlas: Remove code to set trigger parent > iio: as3935: Remove code to set trigger parent > iio: Rename iio_trigger_alloc dev argument to parent > > drivers/iio/accel/adxl372.c | 2 -- > drivers/iio/accel/bma180.c | 3 +- > drivers/iio/accel/bmc150-accel-core.c | 1 - > drivers/iio/accel/kxcjk-1013.c | 2 -- > drivers/iio/accel/mma8452.c | 1 - > drivers/iio/accel/mxc4005.c | 1 - > drivers/iio/accel/stk8312.c | 1 - > drivers/iio/accel/stk8ba50.c | 1 - > drivers/iio/adc/ad7606.c | 1 - > drivers/iio/adc/ad7766.c | 1 - > drivers/iio/adc/ad7768-1.c | 1 - > drivers/iio/adc/ad_sigma_delta.c | 4 +-- > drivers/iio/adc/at91_adc.c | 3 +- > drivers/iio/adc/max1027.c | 1 - > drivers/iio/adc/xilinx-xadc-core.c | 4 +-- > drivers/iio/chemical/atlas-sensor.c | 1 - > drivers/iio/chemical/ccs811.c | 1 - > drivers/iio/chemical/scd30_core.c | 1 - > .../common/hid-sensors/hid-sensor-trigger.c | 4 +-- > .../common/st_sensors/st_sensors_trigger.c | 4 +-- > drivers/iio/gyro/adxrs290.c | 1 - > drivers/iio/gyro/bmg160_core.c | 2 -- > drivers/iio/gyro/fxas21002c_core.c | 1 - > drivers/iio/gyro/itg3200_buffer.c | 3 +- > drivers/iio/health/afe4403.c | 1 - > drivers/iio/health/afe4404.c | 1 - > drivers/iio/humidity/hts221_buffer.c | 1 - > drivers/iio/imu/adis_trigger.c | 10 ++---- > drivers/iio/imu/kmx61.c | 1 - > drivers/iio/industrialio-trigger.c | 33 +++++++++++-------- > drivers/iio/light/gp2ap020a00f.c | 1 - > drivers/iio/light/rpr0521.c | 1 - > drivers/iio/light/si1145.c | 1 - > drivers/iio/light/st_uvis25_core.c | 1 - > drivers/iio/light/vcnl4000.c | 1 - > drivers/iio/light/vcnl4035.c | 1 - > drivers/iio/magnetometer/bmc150_magn.c | 1 - > drivers/iio/magnetometer/rm3100-core.c | 1 - > drivers/iio/potentiostat/lmp91000.c | 3 +- > drivers/iio/pressure/zpa2326.c | 1 - > drivers/iio/proximity/as3935.c | 1 - > drivers/iio/proximity/sx9310.c | 1 - > drivers/iio/proximity/sx932x.c | 1 - > drivers/iio/proximity/sx9500.c | 1 - > drivers/iio/trigger/iio-trig-hrtimer.c | 2 +- > drivers/iio/trigger/iio-trig-interrupt.c | 2 +- > drivers/iio/trigger/iio-trig-loop.c | 2 +- > drivers/iio/trigger/iio-trig-sysfs.c | 3 +- > include/linux/iio/iio.h | 2 +- > include/linux/iio/trigger.h | 3 +- > 50 files changed, 41 insertions(+), 81 deletions(-) >