* [PATCH] drivers: fixes wrong ADC result due to incorrect bit mask of ad7949 driver
@ 2021-02-06 8:06 Wilfried Wessner
0 siblings, 0 replies; only message in thread
From: Wilfried Wessner @ 2021-02-06 8:06 UTC (permalink / raw)
To: Lars-Peter Clausen, Michael Hennerich, Jonathan Cameron,
Peter Meerwald-Stadler
Cc: linux-iio, gregkh
Fixes a wrong bit mask used for the ADC's result, which was caused by an
improper usage of the GENMASK macro. The bits higher than ADC's
resolution are undefined and if not masked out correctly, a wrong result
can be given. The GENMASK macro indexing is zero based, so the mask has
to go from [resolution -1 , 0].
Signed-off-by: Wilfried Wessner <wilfried.wessner@gmail.com>
---
drivers/iio/adc/ad7949.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/adc/ad7949.c b/drivers/iio/adc/ad7949.c
index 5d597e5050f6..a5b4858cb6dc 100644
--- a/drivers/iio/adc/ad7949.c
+++ b/drivers/iio/adc/ad7949.c
@@ -91,7 +91,7 @@ static int ad7949_spi_read_channel(struct ad7949_adc_chip *ad7949_adc, int *val,
int ret;
int i;
int bits_per_word = ad7949_adc->resolution;
- int mask = GENMASK(ad7949_adc->resolution, 0);
+ int mask = GENMASK((ad7949_adc->resolution-1), 0);
struct spi_message msg;
struct spi_transfer tx[] = {
{
--
2.25.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2021-02-06 8:07 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-02-06 8:06 [PATCH] drivers: fixes wrong ADC result due to incorrect bit mask of ad7949 driver Wilfried Wessner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox