From: Jonathan Cameron <jic23@kernel.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Brendan Higgins <brendanhiggins@google.com>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
linux-iio@vger.kernel.org
Subject: Re: [PATCH 3/3] iio: Add basic unit test for iio_format_value()
Date: Sun, 14 Feb 2021 12:50:22 +0000 [thread overview]
Message-ID: <20210214125022.739e6eba@archlinux> (raw)
In-Reply-To: <8ae67298-5365-6549-1ccd-7de577ca3939@metafoo.de>
On Sun, 7 Feb 2021 13:45:02 +0100
Lars-Peter Clausen <lars@metafoo.de> wrote:
> On 1/2/21 3:59 PM, Lars-Peter Clausen wrote:
> > On 12/29/20 7:16 PM, Jonathan Cameron wrote:
> >> On Tue, 15 Dec 2020 20:17:43 +0100
> >> Lars-Peter Clausen <lars@metafoo.de> wrote:
> >>
> >>> The IIO core provides a function to do formatting of fixedpoint
> >>> numbers.
> >>>
> >>> In the past there have been some issues with the implementation of the
> >>> function where for example negative numbers were not handled correctly.
> >>>
> >>> Introduce a basic unit test based on kunit that tests the function and
> >>> ensures that the generated output matches the expected output.
> >>>
> >>> This gives us some confidence that future modifications to the function
> >>> implementation will not break ABI compatibility.
> >>>
> >>> To run the unit tests follow the kunit documentation and add
> >>>
> >>> CONFIG_IIO=y
> >>> CONFIG_IIO_TEST_FORMAT=y
> >>>
> >>> to the .kunitconfig and run
> >>>
> >>> > ./tools/testing/kunit/kunit.py run
> >>> Configuring KUnit Kernel ...
> >>> Building KUnit Kernel ...
> >>> Starting KUnit Kernel ...
> >>> ============================================================
> >>> ======== [PASSED] iio-format ========
> >>> [PASSED] iio_test_iio_format_value_integer
> >>> [PASSED] iio_test_iio_format_value_fixedpoint
> >>> [PASSED] iio_test_iio_format_value_fractional
> >>> [PASSED] iio_test_iio_format_value_fractional_log2
> >>> [PASSED] iio_test_iio_format_value_multiple
> >>> ============================================================
> >>> Testing complete. 21 tests run. 0 failed. 0 crashed.
> >>> Elapsed time: 8.242s total, 0.001s configuring, 3.865s building,
> >>> 0.000s running
> >>>
> >>> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
> >> Series looks good to me, but I wonder. What is convention wrt to
> >> MAINTAINERS / Acks etc for self tests?
> >
> > Let's ask Brendan.
> >
> Jonathan, since there hasn't been any additional feedback should we just
> apply this series?
>
Sure, it's been long enough.
Applied to the togreg branch of iio.git and pushed out as testing for
all the normal reasons.
Thanks,
Jonathan
> Thanks,
>
> - Lars
>
prev parent reply other threads:[~2021-02-14 12:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-15 19:17 [PATCH 1/3] iio: iio_format_value(): Use signed temporary for IIO_VAL_FRACTIONAL_LOG2 Lars-Peter Clausen
2020-12-15 19:17 ` [PATCH 2/3] iio: iio_format_value(): Fix IIO_VAL_FRACTIONAL_LOG2 values between -1.0 and 0.0 Lars-Peter Clausen
2020-12-15 19:17 ` [PATCH 3/3] iio: Add basic unit test for iio_format_value() Lars-Peter Clausen
2020-12-29 18:16 ` Jonathan Cameron
2021-01-02 14:59 ` Lars-Peter Clausen
2021-02-07 12:45 ` Lars-Peter Clausen
2021-02-14 12:50 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210214125022.739e6eba@archlinux \
--to=jic23@kernel.org \
--cc=brendanhiggins@google.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).