From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 806CFC433DB for ; Mon, 15 Feb 2021 11:19:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4969764E52 for ; Mon, 15 Feb 2021 11:19:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229870AbhBOLTl (ORCPT ); Mon, 15 Feb 2021 06:19:41 -0500 Received: from mail.kernel.org ([198.145.29.99]:48432 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229811AbhBOLTk (ORCPT ); Mon, 15 Feb 2021 06:19:40 -0500 Received: from archlinux (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CDF3764E52; Mon, 15 Feb 2021 11:18:58 +0000 (UTC) Date: Mon, 15 Feb 2021 11:18:48 +0000 From: Jonathan Cameron To: Alexandru Ardelean Cc: , , , , , Subject: Re: [PATCH v6 01/24] iio: adc: ti_am335x_adc: remove omitted iio_kfifo_free() Message-ID: <20210215111848.6312b026@archlinux> In-Reply-To: <20210215104043.91251-2-alexandru.ardelean@analog.com> References: <20210215104043.91251-1-alexandru.ardelean@analog.com> <20210215104043.91251-2-alexandru.ardelean@analog.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Mon, 15 Feb 2021 12:40:20 +0200 Alexandru Ardelean wrote: > When the conversion was done to use devm_iio_kfifo_allocate(), a call to > iio_kfifo_free() was omitted (to be removed). > This change removes it. > > Fixes: 3c5308058899 ("iio: adc: ti_am335x_adc: alloc kfifo & IRQ via devm_ functions") > Signed-off-by: Alexandru Ardelean Hi Alex, I'm going to work my way through the series - may get to the end, but if not hopefully we can at least reduce the number of outstanding patches. To enable that I've rebased my togreg branch of staging/staging-next (I hadn't pushed it out as a non rebasing tree so this shouldn't impact anyone too badly). Therefore, dropping this patch as it's already there. Jonathan > --- > drivers/iio/adc/ti_am335x_adc.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/iio/adc/ti_am335x_adc.c b/drivers/iio/adc/ti_am335x_adc.c > index b11c8c47ba2a..e946903b0993 100644 > --- a/drivers/iio/adc/ti_am335x_adc.c > +++ b/drivers/iio/adc/ti_am335x_adc.c > @@ -397,16 +397,12 @@ static int tiadc_iio_buffered_hardware_setup(struct device *dev, > ret = devm_request_threaded_irq(dev, irq, pollfunc_th, pollfunc_bh, > flags, indio_dev->name, indio_dev); > if (ret) > - goto error_kfifo_free; > + return ret; > > indio_dev->setup_ops = setup_ops; > indio_dev->modes |= INDIO_BUFFER_SOFTWARE; > > return 0; > - > -error_kfifo_free: > - iio_kfifo_free(indio_dev->buffer); > - return ret; > } > > static const char * const chan_name_ain[] = {