From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9C7EC433E0 for ; Mon, 15 Feb 2021 12:45:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A4ADE64DC3 for ; Mon, 15 Feb 2021 12:45:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230351AbhBOMpZ (ORCPT ); Mon, 15 Feb 2021 07:45:25 -0500 Received: from mail.kernel.org ([198.145.29.99]:56992 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230332AbhBOMpT (ORCPT ); Mon, 15 Feb 2021 07:45:19 -0500 Received: from archlinux (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F2E6764DEC; Mon, 15 Feb 2021 12:44:37 +0000 (UTC) Date: Mon, 15 Feb 2021 12:44:34 +0000 From: Jonathan Cameron To: Alexandru Ardelean Cc: , , , , , Subject: Re: [PATCH v6 15/24] iio: buffer: dmaengine: obtain buffer object from attribute Message-ID: <20210215124434.537196ba@archlinux> In-Reply-To: <20210215104043.91251-16-alexandru.ardelean@analog.com> References: <20210215104043.91251-1-alexandru.ardelean@analog.com> <20210215104043.91251-16-alexandru.ardelean@analog.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Mon, 15 Feb 2021 12:40:34 +0200 Alexandru Ardelean wrote: > The reference to the IIO buffer object is stored on the attribute object. > So we need to unwind it to obtain it. > > Signed-off-by: Alexandru Ardelean This could have done with a little more description of 'why', but I'm not going to hold up the series to fix it. Jonathan > --- > drivers/iio/buffer/industrialio-buffer-dmaengine.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/iio/buffer/industrialio-buffer-dmaengine.c b/drivers/iio/buffer/industrialio-buffer-dmaengine.c > index 9981896e1495..a64b222289be 100644 > --- a/drivers/iio/buffer/industrialio-buffer-dmaengine.c > +++ b/drivers/iio/buffer/industrialio-buffer-dmaengine.c > @@ -132,9 +132,9 @@ static const struct iio_dma_buffer_ops iio_dmaengine_default_ops = { > static ssize_t iio_dmaengine_buffer_get_length_align(struct device *dev, > struct device_attribute *attr, char *buf) > { > - struct iio_dev *indio_dev = dev_to_iio_dev(dev); > + struct iio_buffer *buffer = to_iio_dev_attr(attr)->buffer; > struct dmaengine_buffer *dmaengine_buffer = > - iio_buffer_to_dmaengine_buffer(indio_dev->buffer); > + iio_buffer_to_dmaengine_buffer(buffer); > > return sprintf(buf, "%zu\n", dmaengine_buffer->align); > }