From: Jonathan Cameron <jic23@kernel.org>
To: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
Cc: Alexandru Ardelean <alexandru.ardelean@analog.com>,
<linux-kernel@vger.kernel.org>, <linux-iio@vger.kernel.org>,
<lars@metafoo.de>, <Michael.Hennerich@analog.com>,
<nuno.sa@analog.com>, <dragos.bogdan@analog.com>
Subject: Re: [PATCH v2 1/5] iio: Documentation: update definitions for bufferY and scan_elements
Date: Thu, 18 Feb 2021 13:36:03 +0000 [thread overview]
Message-ID: <20210218133603.2ca79632@archlinux> (raw)
In-Reply-To: <20210218121948.000017cd@Huawei.com>
On Thu, 18 Feb 2021 12:19:48 +0000
Jonathan Cameron <Jonathan.Cameron@Huawei.com> wrote:
> On Wed, 17 Feb 2021 10:34:34 +0200
> Alexandru Ardelean <alexandru.ardelean@analog.com> wrote:
>
> > Since the new change to the IIO buffer infrastructure, the buffer/ and
> > scan_elements/ directories have been merged into bufferY/ to have some
> > attributes available per-buffer.
> >
> > This change updates the ABI docs to reflect this change.
> >
> > The hwfifo attributes are not updated, as for now these should be used
> > via the legacy buffer/ directory until they are moved into core.
> >
> > Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
>
> This doesn't really have anything to do with the rest of the set - so ideally
> you'd have sent it separately.
>
> One trivial typo below, that I can fix whilst applying.
Applied with that fix.
Jonathan
>
> > ---
> > Documentation/ABI/testing/sysfs-bus-iio | 85 +++++++++++++++++++++++++
> > 1 file changed, 85 insertions(+)
> >
> > diff --git a/Documentation/ABI/testing/sysfs-bus-iio b/Documentation/ABI/testing/sysfs-bus-iio
> > index d957f5da5c04..f2a72d7fbacb 100644
> > --- a/Documentation/ABI/testing/sysfs-bus-iio
> > +++ b/Documentation/ABI/testing/sysfs-bus-iio
> > @@ -1118,12 +1118,16 @@ Description:
> >
> > What: /sys/bus/iio/devices/iio:deviceX/buffer/length
> > KernelVersion: 2.6.35
> > +What: /sys/bus/iio/devices/iio:deviceX/bufferY/length
> > +KernelVersion: 5.11
> > Contact: linux-iio@vger.kernel.org
> > Description:
> > Number of scans contained by the buffer.
> >
> > What: /sys/bus/iio/devices/iio:deviceX/buffer/enable
> > KernelVersion: 2.6.35
> > +What: /sys/bus/iio/devices/iio:deviceX/bufferY/enable
> > +KernelVersion: 5.11
> > Contact: linux-iio@vger.kernel.org
> > Description:
> > Actually start the buffer capture up. Will start trigger
> > @@ -1131,11 +1135,16 @@ Description:
> >
> > What: /sys/bus/iio/devices/iio:deviceX/scan_elements
> > KernelVersion: 2.6.37
> > +What: /sys/bus/iio/devices/iio:deviceX/buffeY
> bufferY
>
> I'll fix whilst applying.
>
> > +KernelVersion: 5.11
> > Contact: linux-iio@vger.kernel.org
> > Description:
> > Directory containing interfaces for elements that will be
> > captured for a single triggered sample set in the buffer.
> >
> > + Since kernel 5.11 the scan_elements attributes are merged into
> > + the bufferY directory, to be configurable per buffer.
> > +
> > What: /sys/.../iio:deviceX/scan_elements/in_accel_x_en
> > What: /sys/.../iio:deviceX/scan_elements/in_accel_y_en
> > What: /sys/.../iio:deviceX/scan_elements/in_accel_z_en
> > @@ -1164,6 +1173,34 @@ What: /sys/.../iio:deviceX/scan_elements/in_pressure_en
> > What: /sys/.../iio:deviceX/scan_elements/in_rot_quaternion_en
> > What: /sys/.../iio:deviceX/scan_elements/in_proximity_en
> > KernelVersion: 2.6.37
> > +What: /sys/.../iio:deviceX/bufferY/in_accel_x_en
> > +What: /sys/.../iio:deviceX/bufferY/in_accel_y_en
> > +What: /sys/.../iio:deviceX/bufferY/in_accel_z_en
> > +What: /sys/.../iio:deviceX/bufferY/in_anglvel_x_en
> > +What: /sys/.../iio:deviceX/bufferY/in_anglvel_y_en
> > +What: /sys/.../iio:deviceX/bufferY/in_anglvel_z_en
> > +What: /sys/.../iio:deviceX/bufferY/in_magn_x_en
> > +What: /sys/.../iio:deviceX/bufferY/in_magn_y_en
> > +What: /sys/.../iio:deviceX/bufferY/in_magn_z_en
> > +What: /sys/.../iio:deviceX/bufferY/in_rot_from_north_magnetic_en
> > +What: /sys/.../iio:deviceX/bufferY/in_rot_from_north_true_en
> > +What: /sys/.../iio:deviceX/bufferY/in_rot_from_north_magnetic_tilt_comp_en
> > +What: /sys/.../iio:deviceX/bufferY/in_rot_from_north_true_tilt_comp_en
> > +What: /sys/.../iio:deviceX/bufferY/in_timestamp_en
> > +What: /sys/.../iio:deviceX/bufferY/in_voltageY_supply_en
> > +What: /sys/.../iio:deviceX/bufferY/in_voltageY_en
> > +What: /sys/.../iio:deviceX/bufferY/in_voltageY-voltageZ_en
> > +What: /sys/.../iio:deviceX/bufferY/in_voltageY_i_en
> > +What: /sys/.../iio:deviceX/bufferY/in_voltageY_q_en
> > +What: /sys/.../iio:deviceX/bufferY/in_voltage_i_en
> > +What: /sys/.../iio:deviceX/bufferY/in_voltage_q_en
> > +What: /sys/.../iio:deviceX/bufferY/in_incli_x_en
> > +What: /sys/.../iio:deviceX/bufferY/in_incli_y_en
> > +What: /sys/.../iio:deviceX/bufferY/in_pressureY_en
> > +What: /sys/.../iio:deviceX/bufferY/in_pressure_en
> > +What: /sys/.../iio:deviceX/bufferY/in_rot_quaternion_en
> > +What: /sys/.../iio:deviceX/bufferY/in_proximity_en
> > +KernelVersion: 5.11
> > Contact: linux-iio@vger.kernel.org
> > Description:
> > Scan element control for triggered data capture.
> > @@ -1185,6 +1222,23 @@ What: /sys/.../iio:deviceX/scan_elements/in_pressure_type
> > What: /sys/.../iio:deviceX/scan_elements/in_rot_quaternion_type
> > What: /sys/.../iio:deviceX/scan_elements/in_proximity_type
> > KernelVersion: 2.6.37
> > +What: /sys/.../iio:deviceX/bufferY/in_accel_type
> > +What: /sys/.../iio:deviceX/bufferY/in_anglvel_type
> > +What: /sys/.../iio:deviceX/bufferY/in_magn_type
> > +What: /sys/.../iio:deviceX/bufferY/in_incli_type
> > +What: /sys/.../iio:deviceX/bufferY/in_voltageY_type
> > +What: /sys/.../iio:deviceX/bufferY/in_voltage_type
> > +What: /sys/.../iio:deviceX/bufferY/in_voltageY_supply_type
> > +What: /sys/.../iio:deviceX/bufferY/in_voltageY_i_type
> > +What: /sys/.../iio:deviceX/bufferY/in_voltageY_q_type
> > +What: /sys/.../iio:deviceX/bufferY/in_voltage_i_type
> > +What: /sys/.../iio:deviceX/bufferY/in_voltage_q_type
> > +What: /sys/.../iio:deviceX/bufferY/in_timestamp_type
> > +What: /sys/.../iio:deviceX/bufferY/in_pressureY_type
> > +What: /sys/.../iio:deviceX/bufferY/in_pressure_type
> > +What: /sys/.../iio:deviceX/bufferY/in_rot_quaternion_type
> > +What: /sys/.../iio:deviceX/bufferY/in_proximity_type
> > +KernelVersion: 5.11
> > Contact: linux-iio@vger.kernel.org
> > Description:
> > Description of the scan element data storage within the buffer
> > @@ -1241,6 +1295,33 @@ What: /sys/.../iio:deviceX/scan_elements/in_pressure_index
> > What: /sys/.../iio:deviceX/scan_elements/in_rot_quaternion_index
> > What: /sys/.../iio:deviceX/scan_elements/in_proximity_index
> > KernelVersion: 2.6.37
> > +What: /sys/.../iio:deviceX/bufferY/in_voltageY_index
> > +What: /sys/.../iio:deviceX/bufferY/in_voltageY_supply_index
> > +What: /sys/.../iio:deviceX/bufferY/in_voltageY_i_index
> > +What: /sys/.../iio:deviceX/bufferY/in_voltageY_q_index
> > +What: /sys/.../iio:deviceX/bufferY/in_voltage_i_index
> > +What: /sys/.../iio:deviceX/bufferY/in_voltage_q_index
> > +What: /sys/.../iio:deviceX/bufferY/in_accel_x_index
> > +What: /sys/.../iio:deviceX/bufferY/in_accel_y_index
> > +What: /sys/.../iio:deviceX/bufferY/in_accel_z_index
> > +What: /sys/.../iio:deviceX/bufferY/in_anglvel_x_index
> > +What: /sys/.../iio:deviceX/bufferY/in_anglvel_y_index
> > +What: /sys/.../iio:deviceX/bufferY/in_anglvel_z_index
> > +What: /sys/.../iio:deviceX/bufferY/in_magn_x_index
> > +What: /sys/.../iio:deviceX/bufferY/in_magn_y_index
> > +What: /sys/.../iio:deviceX/bufferY/in_magn_z_index
> > +What: /sys/.../iio:deviceX/bufferY/in_rot_from_north_magnetic_index
> > +What: /sys/.../iio:deviceX/bufferY/in_rot_from_north_true_index
> > +What: /sys/.../iio:deviceX/bufferY/in_rot_from_north_magnetic_tilt_comp_index
> > +What: /sys/.../iio:deviceX/bufferY/in_rot_from_north_true_tilt_comp_index
> > +What: /sys/.../iio:deviceX/bufferY/in_incli_x_index
> > +What: /sys/.../iio:deviceX/bufferY/in_incli_y_index
> > +What: /sys/.../iio:deviceX/bufferY/in_timestamp_index
> > +What: /sys/.../iio:deviceX/bufferY/in_pressureY_index
> > +What: /sys/.../iio:deviceX/bufferY/in_pressure_index
> > +What: /sys/.../iio:deviceX/bufferY/in_rot_quaternion_index
> > +What: /sys/.../iio:deviceX/bufferY/in_proximity_index
> > +KernelVersion: 5.11
> > Contact: linux-iio@vger.kernel.org
> > Description:
> > A single positive integer specifying the position of this
> > @@ -1455,6 +1536,8 @@ Description:
> >
> > What: /sys/bus/iio/devices/iio:deviceX/buffer/watermark
> > KernelVersion: 4.2
> > +What: /sys/bus/iio/devices/iio:deviceX/bufferY/watermark
> > +KernelVersion: 5.11
> > Contact: linux-iio@vger.kernel.org
> > Description:
> > A single positive integer specifying the maximum number of scan
> > @@ -1473,6 +1556,8 @@ Description:
> >
> > What: /sys/bus/iio/devices/iio:deviceX/buffer/data_available
> > KernelVersion: 4.16
> > +What: /sys/bus/iio/devices/iio:deviceX/bufferY/data_available
> > +KernelVersion: 5.11
> > Contact: linux-iio@vger.kernel.org
> > Description:
> > A read-only value indicating the bytes of data available in the
>
next prev parent reply other threads:[~2021-02-18 15:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-17 8:34 [PATCH v2 0/5] iio: Add output buffer support Alexandru Ardelean
2021-02-17 8:34 ` [PATCH v2 1/5] iio: Documentation: update definitions for bufferY and scan_elements Alexandru Ardelean
2021-02-18 12:19 ` Jonathan Cameron
2021-02-18 13:36 ` Jonathan Cameron [this message]
2021-04-01 13:44 ` Mauro Carvalho Chehab
2021-04-01 15:00 ` Jonathan Cameron
2021-02-17 8:34 ` [PATCH v2 2/5] iio: Add output buffer support Alexandru Ardelean
2021-02-18 13:42 ` Jonathan Cameron
2021-02-19 8:45 ` Alexandru Ardelean
2021-02-17 8:34 ` [PATCH v2 3/5] iio: kfifo-buffer: " Alexandru Ardelean
2021-02-17 8:34 ` [PATCH v2 4/5] iio: triggered-buffer: extend support to configure output buffers Alexandru Ardelean
2021-02-17 8:34 ` [PATCH v2 5/5] iio: dac: ad5686: Add PWM as a trigger source Alexandru Ardelean
2021-02-18 14:05 ` Jonathan Cameron
2021-02-18 14:35 ` Rob Herring
2021-02-19 8:49 ` Alexandru Ardelean
2021-02-23 16:37 ` Lars-Peter Clausen
2021-02-27 15:45 ` Jonathan Cameron
2021-02-18 13:38 ` [PATCH v2 0/5] iio: Add output buffer support Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210218133603.2ca79632@archlinux \
--to=jic23@kernel.org \
--cc=Jonathan.Cameron@Huawei.com \
--cc=Michael.Hennerich@analog.com \
--cc=alexandru.ardelean@analog.com \
--cc=dragos.bogdan@analog.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox