From: Jonathan Cameron <jic23@kernel.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-iio@vger.kernel.org, Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Gene Chen <gene_chen@richtek.com>,
Harvey Harrison <harvey.harrison@gmail.com>
Subject: Re: [PATCH] iio: adc: mt6360: Include right header
Date: Sun, 21 Feb 2021 15:47:58 +0000 [thread overview]
Message-ID: <20210221154758.10aa25a3@archlinux> (raw)
In-Reply-To: <20210215153447.48457-1-linus.walleij@linaro.org>
On Mon, 15 Feb 2021 16:34:47 +0100
Linus Walleij <linus.walleij@linaro.org> wrote:
> To get access to the big endian byte order parsing helpers
> drivers need to include <asm/unaligned.h> and nothing else.
>
> Cc: Gene Chen <gene_chen@richtek.com>
> Suggested-by: Harvey Harrison <harvey.harrison@gmail.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Applied to the togreg branch of iio.git and pushed out as testing for
all the normal reasons.
I'm not rushing this one through as it's a SoC ADC so I assume the
endian choice is right, even though not how it should be done.
Jonathan
> ---
> drivers/iio/adc/mt6360-adc.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/mt6360-adc.c b/drivers/iio/adc/mt6360-adc.c
> index f57db3056fbe..6b39a139ce28 100644
> --- a/drivers/iio/adc/mt6360-adc.c
> +++ b/drivers/iio/adc/mt6360-adc.c
> @@ -9,13 +9,14 @@
> #include <linux/mutex.h>
> #include <linux/platform_device.h>
> #include <linux/regmap.h>
> -#include <linux/unaligned/be_byteshift.h>
>
> #include <linux/iio/buffer.h>
> #include <linux/iio/iio.h>
> #include <linux/iio/trigger_consumer.h>
> #include <linux/iio/triggered_buffer.h>
>
> +#include <asm/unaligned.h>
> +
> #define MT6360_REG_PMUCHGCTRL3 0x313
> #define MT6360_REG_PMUADCCFG 0x356
> #define MT6360_REG_PMUADCIDLET 0x358
prev parent reply other threads:[~2021-02-21 15:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-15 15:34 [PATCH] iio: adc: mt6360: Include right header Linus Walleij
2021-02-21 15:47 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210221154758.10aa25a3@archlinux \
--to=jic23@kernel.org \
--cc=gene_chen@richtek.com \
--cc=harvey.harrison@gmail.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox