* [PATCH] iio: adc: mt6360: Include right header
@ 2021-02-15 15:34 Linus Walleij
2021-02-21 15:47 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Linus Walleij @ 2021-02-15 15:34 UTC (permalink / raw)
To: Jonathan Cameron, linux-iio
Cc: Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald-Stadler,
Linus Walleij, Gene Chen, Harvey Harrison
To get access to the big endian byte order parsing helpers
drivers need to include <asm/unaligned.h> and nothing else.
Cc: Gene Chen <gene_chen@richtek.com>
Suggested-by: Harvey Harrison <harvey.harrison@gmail.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
drivers/iio/adc/mt6360-adc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/iio/adc/mt6360-adc.c b/drivers/iio/adc/mt6360-adc.c
index f57db3056fbe..6b39a139ce28 100644
--- a/drivers/iio/adc/mt6360-adc.c
+++ b/drivers/iio/adc/mt6360-adc.c
@@ -9,13 +9,14 @@
#include <linux/mutex.h>
#include <linux/platform_device.h>
#include <linux/regmap.h>
-#include <linux/unaligned/be_byteshift.h>
#include <linux/iio/buffer.h>
#include <linux/iio/iio.h>
#include <linux/iio/trigger_consumer.h>
#include <linux/iio/triggered_buffer.h>
+#include <asm/unaligned.h>
+
#define MT6360_REG_PMUCHGCTRL3 0x313
#define MT6360_REG_PMUADCCFG 0x356
#define MT6360_REG_PMUADCIDLET 0x358
--
2.29.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] iio: adc: mt6360: Include right header
2021-02-15 15:34 [PATCH] iio: adc: mt6360: Include right header Linus Walleij
@ 2021-02-21 15:47 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2021-02-21 15:47 UTC (permalink / raw)
To: Linus Walleij
Cc: linux-iio, Hartmut Knaack, Lars-Peter Clausen,
Peter Meerwald-Stadler, Gene Chen, Harvey Harrison
On Mon, 15 Feb 2021 16:34:47 +0100
Linus Walleij <linus.walleij@linaro.org> wrote:
> To get access to the big endian byte order parsing helpers
> drivers need to include <asm/unaligned.h> and nothing else.
>
> Cc: Gene Chen <gene_chen@richtek.com>
> Suggested-by: Harvey Harrison <harvey.harrison@gmail.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Applied to the togreg branch of iio.git and pushed out as testing for
all the normal reasons.
I'm not rushing this one through as it's a SoC ADC so I assume the
endian choice is right, even though not how it should be done.
Jonathan
> ---
> drivers/iio/adc/mt6360-adc.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/mt6360-adc.c b/drivers/iio/adc/mt6360-adc.c
> index f57db3056fbe..6b39a139ce28 100644
> --- a/drivers/iio/adc/mt6360-adc.c
> +++ b/drivers/iio/adc/mt6360-adc.c
> @@ -9,13 +9,14 @@
> #include <linux/mutex.h>
> #include <linux/platform_device.h>
> #include <linux/regmap.h>
> -#include <linux/unaligned/be_byteshift.h>
>
> #include <linux/iio/buffer.h>
> #include <linux/iio/iio.h>
> #include <linux/iio/trigger_consumer.h>
> #include <linux/iio/triggered_buffer.h>
>
> +#include <asm/unaligned.h>
> +
> #define MT6360_REG_PMUCHGCTRL3 0x313
> #define MT6360_REG_PMUADCCFG 0x356
> #define MT6360_REG_PMUADCIDLET 0x358
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-21 15:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-02-15 15:34 [PATCH] iio: adc: mt6360: Include right header Linus Walleij
2021-02-21 15:47 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox