From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21563C433E0 for ; Sun, 21 Feb 2021 15:54:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CF13464EF1 for ; Sun, 21 Feb 2021 15:54:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230036AbhBUPyC (ORCPT ); Sun, 21 Feb 2021 10:54:02 -0500 Received: from mail.kernel.org ([198.145.29.99]:44590 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230016AbhBUPyA (ORCPT ); Sun, 21 Feb 2021 10:54:00 -0500 Received: from archlinux (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4DB1064EF1; Sun, 21 Feb 2021 15:53:17 +0000 (UTC) Date: Sun, 21 Feb 2021 15:53:14 +0000 From: Jonathan Cameron To: Stephen Boyd Cc: linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, Dmitry Torokhov , Benson Leung , Guenter Roeck , Douglas Anderson , Gwendal Grignou , Enric Balletbo i Serra Subject: Re: [PATCH v6 3/3] iio: proximity: Add a ChromeOS EC MKBP proximity driver Message-ID: <20210221155314.56f55e85@archlinux> In-Reply-To: <161333519805.1254594.18000613822693540497@swboyd.mtv.corp.google.com> References: <20210211024601.1963379-1-swboyd@chromium.org> <20210211024601.1963379-4-swboyd@chromium.org> <20210214124809.4abfa363@archlinux> <161333519805.1254594.18000613822693540497@swboyd.mtv.corp.google.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Sun, 14 Feb 2021 12:39:58 -0800 Stephen Boyd wrote: > Quoting Jonathan Cameron (2021-02-14 04:48:09) > > On Wed, 10 Feb 2021 18:46:01 -0800 > > Stephen Boyd wrote: > > > > > Add support for a ChromeOS EC proximity driver that exposes a "front" > > > proximity sensor via the IIO subsystem. The EC decides when front > > > proximity is near and sets an MKBP switch 'EC_MKBP_FRONT_PROXIMITY' to > > > notify the kernel of proximity. Similarly, when proximity detects > > > something far away it sets the switch bit to 0. For now this driver > > > exposes a single sensor, but it could be expanded in the future via more > > > MKBP bits if desired. > > > > > > Cc: Dmitry Torokhov > > > Cc: Benson Leung > > > Cc: Guenter Roeck > > > Cc: Douglas Anderson > > > Cc: Gwendal Grignou > > > Reviewed-by: Enric Balletbo i Serra > > > Signed-off-by: Stephen Boyd > > > > I'm fine with this, but want to leave a little time for others to take > > one last look. We've missed the coming merge window now anyway. > > > > If I seem to have forgotten this in a couple of weeks, feel free to > > give me a bump. > > > > Ok no problem. Gwendal had some comments on v5 that may be applicable > here too but I think they mostly mean that the resume handler may not be > needed if cros ec is fixed. Having the resume handler shouldn't hurt > though unless I missed something. Gwendal? @Gwendal, could you take a quick glance at this, or alternatively let us know if you need more time to get to it. Thanks, Jonathan