From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
To: Utkarsh Verma <utkarshverma294@gmail.com>
Cc: <linux-iio@vger.kernel.org>, <dragos.bogdan@analog.com>,
Gwendal Grignou <gwendal@chromium.org>
Subject: Re: Contribution to linux-iio for GSOC 2021
Date: Wed, 10 Mar 2021 18:18:43 +0000 [thread overview]
Message-ID: <20210310181843.00001b8f@huawei.com> (raw)
In-Reply-To: <20210310174535.00007ae2@Huawei.com>
On Wed, 10 Mar 2021 17:45:35 +0000
Jonathan Cameron <Jonathan.Cameron@Huawei.com> wrote:
> On Wed, 10 Mar 2021 19:24:39 +0530
> Utkarsh Verma <utkarshverma294@gmail.com> wrote:
>
> > Hello,
> >
> > This is Utkarsh Verma. I am a 3rd year Bachelor of Technology
> > Undergrad in Electronics Engineering from HBTU, Kanpur, India.
> >
> > I want to participate in GSOC this summer, by contributing to the IIO
> > subsystem. But more importantly, I want to be a part of this community
> > and get my hands dirty.
> >
> > I have done the operating system course and know the very basics of
> > Linux Kernel. I have also read some chapters of the "Linux Device
> > Drivers" book. I am very new to the iio subsystem and I am still
> > reading the documentation and the conversation on the mailing list. So
> > if anyone can suggest some easy fixes/tasks for getting started would
> > really be appreciated.
> >
> > I would be really happy to contribute.
> >
> > Regards,
> > Utkarsh Verma
>
> Hi Utkarsh,
>
> Welcome to IIO.
>
> If you want a practical immediate task to make sure you have flow
> of submitting patches etc correct, one issue we've just started seeing
> is that when we do
>
> make W=1
>
> we get some misleading reports like:
>
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git testing
> > head: 4ef57c4862e38e6034978d8b247a511292d7055a
> > commit: 1cabd1c21b2a6c5b0dd3fdcffe0b24c1d0e4fc38 [72/74] iio: hrtimer: Allow sub Hz granularity
> > config: x86_64-randconfig-a011-20210308 (attached as .config)
> > compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 3a11a41795bec548e91621caaa4cc00fc31b2212)
> > reproduce (this is a W=1 build):
> > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > chmod +x ~/bin/make.cross
> > # install x86_64 cross compiling tool for clang build
> > # apt-get install binutils-x86-64-linux-gnu
> > # https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git/commit/?id=1cabd1c21b2a6c5b0dd3fdcffe0b24c1d0e4fc38
> > git remote add iio https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git
> > git fetch --no-tags iio testing
> > git checkout 1cabd1c21b2a6c5b0dd3fdcffe0b24c1d0e4fc38
> > # save the attached .config to linux build tree
> > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
> >
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <lkp@intel.com>
> >
> > All warnings (new ones prefixed by >>):
> >
> > >> drivers/iio/trigger/iio-trig-hrtimer.c:20: warning: expecting prototype for O periodic hrtimer trigger driver(). Prototype was for PSEC_PER_SEC() instead
> >
> >
> > vim +20 drivers/iio/trigger/iio-trig-hrtimer.c
> >
> > 18
> > 19 /* Defined locally, not in time64.h yet. */
> > > 20 #define PSEC_PER_SEC 1000000000000LL
> > 21
> >
>
> Gwendal figured out what was going on. It's down to an incorrect marking of the
> initial comment block (where copyright notice etc is ) as kernel doc
> by prefixing it with /**
>
> If you'd like to first fine one of those cases and send a patch fixing it that
> would be great. Once we've sanity checked that first one for process issues etc
> you could then ensure there are no other instances in IIO.
>
> No problem if not and you want something more substantial to start with.
> This is just something that hit my inbox today that I'd otherwise clean up,
> but seemed like a good task for anyone wanting to get started!
Actually scrap that idea. Serves me right for not reading all my IIO related emails
but Gwendal already sent out a patch fixing them all. Sorry!
Jonathan
>
> Thanks,
>
> Jonathan
next prev parent reply other threads:[~2021-03-10 18:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-10 13:54 Contribution to linux-iio for GSOC 2021 Utkarsh Verma
2021-03-10 17:45 ` Jonathan Cameron
2021-03-10 18:18 ` Jonathan Cameron [this message]
2021-03-11 8:57 ` Alexandru Ardelean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210310181843.00001b8f@huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=dragos.bogdan@analog.com \
--cc=gwendal@chromium.org \
--cc=linux-iio@vger.kernel.org \
--cc=utkarshverma294@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox