From: Jonathan Cameron <jic23@kernel.org>
To: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc: linux-iio@vger.kernel.org,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Guenter Roeck <groeck@chromium.org>,
Douglas Anderson <dianders@chromium.org>,
Gwendal Grignou <gwendal@chromium.org>
Subject: Re: [PATCH] iio:cros_ec_sensors: Fix a wrong function name in kernel doc.
Date: Sat, 20 Mar 2021 14:34:41 +0000 [thread overview]
Message-ID: <20210320143441.4da84139@jic23-huawei> (raw)
In-Reply-To: <e0d1caa8-785b-6789-3f8c-08ae5eafca4b@collabora.com>
On Mon, 15 Mar 2021 11:35:44 +0100
Enric Balletbo i Serra <enric.balletbo@collabora.com> wrote:
> Hi Jonathan,
>
> Thank you for fix this.
>
> On 13/3/21 15:53, Jonathan Cameron wrote:
> > From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> >
> > cros_ec_sensors_read_data_unsafe() had wrong function name in kernel-doc
> > This shows up with W=1 builds.
> >
> > No fixes tag because I don't want to waste time on this being
> > backported.
> >
> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > Cc: Guenter Roeck <groeck@chromium.org>
> > Cc: Douglas Anderson <dianders@chromium.org>
> > Cc: Gwendal Grignou <gwendal@chromium.org>
> > Cc: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> > ---
> > drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c b/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c
> > index f8824afe595e..ed9dd0ad5c03 100644
> > --- a/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c
> > +++ b/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c
> > @@ -559,7 +559,7 @@ static int cros_ec_sensors_read_until_not_busy(
> > }
> >
> > /**
> > - * read_ec_sensors_data_unsafe() - read acceleration data from EC shared memory
> > + * cros_ec_sensors_read_data_unsafe() - read acc data from EC shared memory
>
>
> nit: Wouldn't be better to maintain the word 'acceleration' instead of replacing
> for 'acc'. It is less than 100 characters in total so should be fine.
I've put it back whilst applying.
>
> In any case:
>
> Acked-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Applied. Thanks,
Jonathan
>
> > * @indio_dev: pointer to IIO device
> > * @scan_mask: bitmap of the sensor indices to scan
> > * @data: location to store data
> >
prev parent reply other threads:[~2021-03-20 14:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-13 14:53 [PATCH] iio:cros_ec_sensors: Fix a wrong function name in kernel doc Jonathan Cameron
2021-03-15 10:35 ` Enric Balletbo i Serra
2021-03-20 14:34 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210320143441.4da84139@jic23-huawei \
--to=jic23@kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=dianders@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=groeck@chromium.org \
--cc=gwendal@chromium.org \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox