Linux IIO development
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-iio@vger.kernel.org, Ye Xiang <xiang.ye@intel.com>
Subject: Re: [PULL] 1st set of IIO and counter new device support and core changes for the 5.13 cycle.
Date: Fri, 26 Mar 2021 11:38:28 +0000	[thread overview]
Message-ID: <20210326113828.7b125221@jic23-huawei> (raw)
In-Reply-To: <YF3BVjBTwP9ZOMuY@kroah.com>

On Fri, 26 Mar 2021 12:11:18 +0100
Greg KH <gregkh@linuxfoundation.org> wrote:

> On Fri, Mar 26, 2021 at 10:54:36AM +0000, Jonathan Cameron wrote:
> > On Fri, 26 Mar 2021 10:46:56 +0000
> > Jonathan Cameron <jic23@kernel.org> wrote:
> >   
> > > The following changes since commit c972c2d821ca3eda001a20dbe2ca0b4718838caf:
> > > 
> > >   staging: unisys: visornic: Fix repeated words in comments (2021-03-10 09:25:33 +0100)
> > > 
> > > are available in the Git repository at:
> > > 
> > >   https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git tags/iio-for-5.13a
> > > 
> > > for you to fetch changes up to 1b33dfa5d5f165782a1cb18ba1350a42d5d7a579:
> > > 
> > >   Merge remote-tracking branch 'local/ib-iio-scmi-5.12-rc2-take3' into togreg (2021-03-26 10:23:46 +0000)  
> > 
> > Hi Greg,
> > 
> > There is a conflict merging this into staging/staging-next that needs
> > manual resolution.  It is is in hid-sensor-prox.c and resolution I would
> > recommend is to drop the block that is in staging-next.
> > 
> > @@ -220,29 +225,6 @@ static int prox_parse_report(struct platform_device *pdev,
> >         dev_dbg(&pdev->dev, "prox %x:%x\n", st->prox_attr.index,
> >                         st->prox_attr.report_id);
> >  
> > -       /* Set Sensitivity field ids, when there is no individual modifier */
> > -       if (st->common_attributes.sensitivity.index < 0) {
> > -               sensor_hub_input_get_attribute_info(hsdev,
> > -                       HID_FEATURE_REPORT, usage_id,
> > -                       HID_USAGE_SENSOR_DATA_MOD_CHANGE_SENSITIVITY_ABS |
> > -                       HID_USAGE_SENSOR_DATA_PRESENCE,
> > -                       &st->common_attributes.sensitivity);
> > -               dev_dbg(&pdev->dev, "Sensitivity index:report %d:%d\n",
> > -                       st->common_attributes.sensitivity.index,
> > -                       st->common_attributes.sensitivity.report_id);
> > -       }
> > -       if (st->common_attributes.sensitivity.index < 0)
> > -               sensor_hub_input_get_attribute_info(hsdev,
> > -                       HID_FEATURE_REPORT, usage_id,
> > -                       HID_USAGE_SENSOR_DATA_MOD_CHANGE_SENSITIVITY_ABS |
> > -                       HID_USAGE_SENSOR_HUMAN_PRESENCE,
> > -                       &st->common_attributes.sensitivity);
> > -
> > -       st->scale_precision = hid_sensor_format_scale(
> > -                               hsdev->usage,
> > -                               &st->prox_attr,
> > -                               &st->scale_pre_decml, &st->scale_post_decml);
> > -
> >         return ret;
> >  }
> > 
> > Ye Xiang, if that looks wrong to you let us know.  
> 
> That worked for me.
> 
> Note, I get the following "warning" from my scripts when trying to merge
> this:
> 
>  Commit: 0463e60f0870 ("iio: adis16480: fix pps mode sampling frequency math")
> 	Fixes tag: Fixes: 326e2357553d3 ("iio: imu: adis16480: Add support for external clock")
> 	Has these problem(s):
> 	        - empty lines surround the Fixes tag
> 
> I'm going to ignore this, but expect a message from the linux-next
> maintainer about this :(

Doh, seems I need to upgrade my checking scripts (or eyes)

Thanks,

Jonathan

> 
> thanks,
> 
> greg k-h


      reply	other threads:[~2021-03-26 11:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-26 10:46 [PULL] 1st set of IIO and counter new device support and core changes for the 5.13 cycle Jonathan Cameron
2021-03-26 10:54 ` Jonathan Cameron
2021-03-26 11:11   ` Greg KH
2021-03-26 11:38     ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210326113828.7b125221@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=xiang.ye@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox