From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18C6CC433E2 for ; Mon, 29 Mar 2021 10:26:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D888361976 for ; Mon, 29 Mar 2021 10:26:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232012AbhC2KZg (ORCPT ); Mon, 29 Mar 2021 06:25:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:42112 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231724AbhC2KZ2 (ORCPT ); Mon, 29 Mar 2021 06:25:28 -0400 Received: from jic23-huawei (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3D9F761584; Mon, 29 Mar 2021 10:25:26 +0000 (UTC) Date: Mon, 29 Mar 2021 11:25:32 +0100 From: Jonathan Cameron To: Oleksij Rempel Cc: Rob Herring , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Pengutronix Kernel Team , David Jander , Robin van der Gracht , linux-iio@vger.kernel.org, Lars-Peter Clausen , Peter Meerwald-Stadler , Dmitry Torokhov Subject: Re: [PATCH v5 1/3] dt-bindings:iio:adc: add generic settling-time-us and oversampling-ratio channel properties Message-ID: <20210329112532.174825d6@jic23-huawei> In-Reply-To: <20210329073131.1759-2-o.rempel@pengutronix.de> References: <20210329073131.1759-1-o.rempel@pengutronix.de> <20210329073131.1759-2-o.rempel@pengutronix.de> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Mon, 29 Mar 2021 09:31:29 +0200 Oleksij Rempel wrote: > Settling time and over sampling is a typical challenge for different IIO ADC > devices. So, introduce channel specific settling-time-us and oversampling-ratio > properties to cover this use case. > > Signed-off-by: Oleksij Rempel > --- > Documentation/devicetree/bindings/iio/adc/adc.yaml | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/Documentation/devicetree/bindings/iio/adc/adc.yaml b/Documentation/devicetree/bindings/iio/adc/adc.yaml > index 912a7635edc4..d5bc86d2a2af 100644 > --- a/Documentation/devicetree/bindings/iio/adc/adc.yaml > +++ b/Documentation/devicetree/bindings/iio/adc/adc.yaml > @@ -39,4 +39,12 @@ properties: > The first value specifies the positive input pin, the second > specifies the negative input pin. > > + settling-time-us: > + description: > + Time between enabling the channel and firs stable readings. first > + > + oversampling-ratio: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: Number of data samples which are averaged for each read. I think I've asked about this in previous reviews, but I want a clear statement of why you think this property is a feature of the 'board' (and hence should be in device tree) rather than setting sensible defaults and leaving any control to userspace? Jonathan > + > additionalProperties: true