From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F519C43462 for ; Thu, 1 Apr 2021 18:46:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 67936610CF for ; Thu, 1 Apr 2021 18:46:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235115AbhDASqG (ORCPT ); Thu, 1 Apr 2021 14:46:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:35182 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235778AbhDASnC (ORCPT ); Thu, 1 Apr 2021 14:43:02 -0400 Received: from jic23-huawei (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8C22761364; Thu, 1 Apr 2021 15:05:47 +0000 (UTC) Date: Thu, 1 Apr 2021 16:05:57 +0100 From: Jonathan Cameron To: Mugilraj D Cc: Jonathan Cameron , Andy Shevchenko , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Ray Jui , Scott Branden , bcm-kernel-feedback-list , linux-iio , linux-arm Mailing List , Linux Kernel Mailing List Subject: Re: [PATCH] iio: adc: bcm_iproc_adc: Use %s and __func__ Message-ID: <20210401160557.533bae90@jic23-huawei> In-Reply-To: References: <20210401062517.28832-1-dmugil2000@gmail.com> <20210401113015.00006b70@Huawei.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Thu, 1 Apr 2021 20:22:47 +0530 Mugilraj D wrote: > On 01/04/21 4:00 pm, Jonathan Cameron wrote: > > On Thu, 1 Apr 2021 12:24:50 +0300 > > Andy Shevchenko wrote: > > > >> On Thu, Apr 1, 2021 at 9:27 AM Mugilraj Dhavachelvan > >> wrote: > >>> > >>> Change function's name to %s and __func__ to fix checkpatch.pl errors. > >> > >> No, just drop the __func__ completely. First of all, we have a device > >> name, and uniqueness of the messages in the driver should guarantee > >> easy findings. Second, specific to _dbg() variants, with enabled > >> Dynamic Debug it can be chosen at run time! > >> > >> I recommend going through all drivers and drop __func__ near to > >> dev_dbg() and pr_debug(). > >> > > > > Agreed. Though beware that some maintainers will count this > > as noise and get grumpy. > > > > I'm fine with such patches for IIO. > > Sorry for the noise. I just seen the docs about dynamic debug. > So, if we use dev_dbg("log_msg") it will print statement like > filename:lineno [module]func flag log_msg, If I get it correctly. > And no need of specifying __func__ in dev_dbg() and dp_dbg() right!! > > Jonathan do you have any TODO's? I tend not to mind cleanup patches (within reason)in IIO so I'm absolutely fine with a series removing any __func__ items like this. One patch per driver preferred because it avoids issues with this interfering with backports etc. There will end up being about 18 patches from a quick grep. Perhaps send a small number first though to avoid having to put in too much effort as any issues likely to affect the whole set. Just be careful with other maintainers, they sometimes strike a different balance for what they consider noise vs useful. Jonathan > > > > > Jonathan > >