Re: [PATCH] iio:adc: Drop false comment about lack of timestamp control

[Jonathan Cameron <jic23@kernel.org>]

On Fri, 2 Apr 2021 10:25:41 +0300
Alexandru Ardelean <ardeleanalex@gmail.com> wrote:

> On Thu, Apr 1, 2021 at 5:56 PM Jonathan Cameron <jic23@kernel.org> wrote:
> >
> > From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> >
> > The timestamp control has been a function implemented in the core of
> > IIO for a long time, so this comment is incorrect and has clearly been
> > cut and paste into all these drivers.
> >
> > The remainder of the comment added nothing and was confusing so dropped
> > that as well.
> >  
> 
> Reviewed-by: Alexandru Ardelean <ardeleanalex@gmail.com>

Applied to the togreg branch of iio.git and push out testing for
all the normal reasons.

Thanks,

Jonathan

> 
> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > Cc: Lars-Peter Clausen <lars@metafoo.de>
> > Cc: Michael Hennerich <Michael.Hennerich@analog.com>
> >
> > ---
> >  drivers/iio/adc/ad7298.c | 6 ------
> >  drivers/iio/adc/ad7887.c | 6 ------
> >  drivers/iio/adc/ad7923.c | 6 ------
> >  drivers/iio/adc/ad799x.c | 6 ------
> >  4 files changed, 24 deletions(-)
> >
> > diff --git a/drivers/iio/adc/ad7298.c b/drivers/iio/adc/ad7298.c
> > index 689ecd5dd563..d2163cb62f4f 100644
> > --- a/drivers/iio/adc/ad7298.c
> > +++ b/drivers/iio/adc/ad7298.c
> > @@ -142,12 +142,6 @@ static int ad7298_update_scan_mode(struct iio_dev *indio_dev,
> >         return 0;
> >  }
> >
> > -/*
> > - * ad7298_trigger_handler() bh of trigger launched polling to ring buffer
> > - *
> > - * Currently there is no option in this driver to disable the saving of
> > - * timestamps within the ring.
> > - */
> >  static irqreturn_t ad7298_trigger_handler(int irq, void *p)
> >  {
> >         struct iio_poll_func *pf = p;
> > diff --git a/drivers/iio/adc/ad7887.c b/drivers/iio/adc/ad7887.c
> > index 4f6f0e0e03ee..9b3cbe1ddc6f 100644
> > --- a/drivers/iio/adc/ad7887.c
> > +++ b/drivers/iio/adc/ad7887.c
> > @@ -109,12 +109,6 @@ static int ad7887_ring_postdisable(struct iio_dev *indio_dev)
> >         return spi_sync(st->spi, &st->msg[AD7887_CH0]);
> >  }
> >
> > -/*
> > - * ad7887_trigger_handler() bh of trigger launched polling to ring buffer
> > - *
> > - * Currently there is no option in this driver to disable the saving of
> > - * timestamps within the ring.
> > - **/
> >  static irqreturn_t ad7887_trigger_handler(int irq, void *p)
> >  {
> >         struct iio_poll_func *pf = p;
> > diff --git a/drivers/iio/adc/ad7923.c b/drivers/iio/adc/ad7923.c
> > index 287f4c13194e..9a649745cd0a 100644
> > --- a/drivers/iio/adc/ad7923.c
> > +++ b/drivers/iio/adc/ad7923.c
> > @@ -192,12 +192,6 @@ static int ad7923_update_scan_mode(struct iio_dev *indio_dev,
> >         return 0;
> >  }
> >
> > -/*
> > - * ad7923_trigger_handler() bh of trigger launched polling to ring buffer
> > - *
> > - * Currently there is no option in this driver to disable the saving of
> > - * timestamps within the ring.
> > - */
> >  static irqreturn_t ad7923_trigger_handler(int irq, void *p)
> >  {
> >         struct iio_poll_func *pf = p;
> > diff --git a/drivers/iio/adc/ad799x.c b/drivers/iio/adc/ad799x.c
> > index 1575b7670207..18bf8386d50a 100644
> > --- a/drivers/iio/adc/ad799x.c
> > +++ b/drivers/iio/adc/ad799x.c
> > @@ -182,12 +182,6 @@ static int ad799x_update_config(struct ad799x_state *st, u16 config)
> >         return 0;
> >  }
> >
> > -/*
> > - * ad799x_trigger_handler() bh of trigger launched polling to ring buffer
> > - *
> > - * Currently there is no option in this driver to disable the saving of
> > - * timestamps within the ring.
> > - **/
> >  static irqreturn_t ad799x_trigger_handler(int irq, void *p)
> >  {
> >         struct iio_poll_func *pf = p;
> > --
> > 2.31.1
> >