From: Nuno Sa <nuno.sa@analog.com>
To: <linux-iio@vger.kernel.org>
Cc: Jonathan Cameron <jic23@kernel.org>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Lars-Peter Clausen <lars@metafoo.de>
Subject: [PATCH 1/7] iio: adis_buffer: do not return ints in irq handlers
Date: Tue, 13 Apr 2021 13:20:59 +0200 [thread overview]
Message-ID: <20210413112105.69458-2-nuno.sa@analog.com> (raw)
In-Reply-To: <20210413112105.69458-1-nuno.sa@analog.com>
On an IRQ handler we should return normal error codes as 'irqreturn_t'
is expected.
Fixes: ccd2b52f4ac69 ("staging:iio: Add common ADIS library")
Signed-off-by: Nuno Sa <nuno.sa@analog.com>
---
drivers/iio/imu/adis_buffer.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/iio/imu/adis_buffer.c b/drivers/iio/imu/adis_buffer.c
index ac354321f63a..f89bce10090a 100644
--- a/drivers/iio/imu/adis_buffer.c
+++ b/drivers/iio/imu/adis_buffer.c
@@ -130,7 +130,7 @@ static irqreturn_t adis_trigger_handler(int irq, void *p)
int ret;
if (!adis->buffer)
- return -ENOMEM;
+ goto irq_done;
if (adis->data->has_paging) {
mutex_lock(&adis->state_lock);
@@ -154,6 +154,7 @@ static irqreturn_t adis_trigger_handler(int irq, void *p)
iio_push_to_buffers_with_timestamp(indio_dev, adis->buffer,
pf->timestamp);
+irq_done:
iio_trigger_notify_done(indio_dev->trig);
return IRQ_HANDLED;
--
2.31.1
next prev parent reply other threads:[~2021-04-13 11:19 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-13 11:20 [PATCH 0/7] Adis IRQ fixes and minor improvements Nuno Sa
2021-04-13 11:20 ` Nuno Sa [this message]
2021-04-14 7:23 ` [PATCH 1/7] iio: adis_buffer: do not return ints in irq handlers Alexandru Ardelean
2021-04-13 11:21 ` [PATCH 2/7] iio: adis16400: " Nuno Sa
2021-04-14 7:23 ` Alexandru Ardelean
2021-04-13 11:21 ` [PATCH 3/7] iio: adis16475: " Nuno Sa
2021-04-14 7:27 ` Alexandru Ardelean
2021-04-15 7:38 ` Sa, Nuno
2021-04-15 8:17 ` Alexandru Ardelean
2021-04-13 11:21 ` [PATCH 4/7] iio: adis16475: re-set max spi transfer Nuno Sa
2021-04-14 7:28 ` Alexandru Ardelean
2021-04-15 7:53 ` Sa, Nuno
2021-04-15 8:16 ` Sa, Nuno
2021-04-18 10:20 ` Jonathan Cameron
2021-04-19 7:47 ` Sa, Nuno
2021-04-19 15:41 ` Jonathan Cameron
2021-04-13 11:21 ` [PATCH 5/7] iio: adis_buffer: check return value on page change Nuno Sa
2021-04-14 7:34 ` Alexandru Ardelean
2021-04-15 7:55 ` Sa, Nuno
2021-04-13 11:21 ` [PATCH 6/7] iio: adis_buffer: don't push data to buffers on failure Nuno Sa
2021-04-14 7:35 ` Alexandru Ardelean
2021-04-15 7:56 ` Sa, Nuno
2021-04-13 11:21 ` [PATCH 7/7] iio: adis_buffer: update device page after changing it Nuno Sa
2021-04-14 7:38 ` Alexandru Ardelean
2021-04-15 7:58 ` Sa, Nuno
2021-04-15 8:20 ` Alexandru Ardelean
2021-04-14 8:37 ` [PATCH 0/7] Adis IRQ fixes and minor improvements Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210413112105.69458-2-nuno.sa@analog.com \
--to=nuno.sa@analog.com \
--cc=Michael.Hennerich@analog.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox