public inbox for linux-iio@vger.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: Jean-Baptiste Maneyrol <JManeyrol@invensense.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Andy Shevchenko <andy.shevchenko@gmail.com>,
	Maxim Schwalm <maxim.schwalm@gmail.com>,
	Svyatoslav Ryhel <clamor95@gmail.com>,
	"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] iio: gyro: mpu3050: Fix reported temperature value
Date: Sat, 24 Apr 2021 11:46:50 +0100	[thread overview]
Message-ID: <20210424114650.6abb21a0@jic23-huawei> (raw)
In-Reply-To: <edd85a7f-4c1f-9d2f-0425-93a6e45f13bb@gmail.com>

On Sat, 24 Apr 2021 07:58:08 +0300
Dmitry Osipenko <digetx@gmail.com> wrote:

> 23.04.2021 13:14, Jean-Baptiste Maneyrol пишет:
> > Hello,
> > 
> > thanks for this work.
> > 
> > Temperature value should obviously be 16 bits signed, thanks for the fix. By looking at our internal datasheets, I can confirm the values for MPU-30x0 family (div by 280 and 23000 offset LSB).
> > 
> > I'm sorry I don't have access to these more than 1 decade old chips, so I cannot test on my side. But there is no reason it wouldn't be OK.
> > 
> > Acked-by: Jean-Baptiste Maneyrol <jmaneyrol@invensense.com>  
> 
> Thank you very much for confirming that the equation is correct, very
> appreciate that.

Thanks. Applied to the fixes-togreg branch of iio.git.
Note these won't go upstream until after rc1 but hopefully will soon after
that.

Thanks for the detective work etc on this!

Jonathan

  reply	other threads:[~2021-04-24 10:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-23  2:09 [PATCH v3] iio: gyro: mpu3050: Fix reported temperature value Dmitry Osipenko
2021-04-23 10:14 ` Jean-Baptiste Maneyrol
2021-04-24  4:58   ` Dmitry Osipenko
2021-04-24 10:46     ` Jonathan Cameron [this message]
2021-04-24 19:44       ` Dmitry Osipenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210424114650.6abb21a0@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=JManeyrol@invensense.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=clamor95@gmail.com \
    --cc=digetx@gmail.com \
    --cc=lars@metafoo.de \
    --cc=linus.walleij@linaro.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maxim.schwalm@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox