From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1C76C433ED for ; Sat, 24 Apr 2021 11:05:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8A630614A7 for ; Sat, 24 Apr 2021 11:05:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231203AbhDXLGg (ORCPT ); Sat, 24 Apr 2021 07:06:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:56908 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229848AbhDXLGf (ORCPT ); Sat, 24 Apr 2021 07:06:35 -0400 Received: from jic23-huawei (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DE98F61574; Sat, 24 Apr 2021 11:05:55 +0000 (UTC) Date: Sat, 24 Apr 2021 12:06:36 +0100 From: Jonathan Cameron To: Alexandru Ardelean Cc: Nuno Sa , linux-iio , Michael Hennerich , Lars-Peter Clausen Subject: Re: [PATCH v2 3/9] iio: adis16475: do not return ints in irq handlers Message-ID: <20210424120636.15565c54@jic23-huawei> In-Reply-To: References: <20210422101911.135630-1-nuno.sa@analog.com> <20210422101911.135630-4-nuno.sa@analog.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Fri, 23 Apr 2021 09:41:26 +0300 Alexandru Ardelean wrote: > On Thu, Apr 22, 2021 at 1:17 PM Nuno Sa wrote: > > > > On an IRQ handler we should return normal error codes as 'irqreturn_t' > > is expected. > > > > Reviewed-by: Alexandru Ardelean > > > Fixes: fff7352bf7a3c ("iio: imu: Add support for adis16475") > > Signed-off-by: Nuno Sa Hi Nuno, This needs a more detailed commit message as it is simply changing the return code. That goto does other stuff. Please add some more info and send a v3 with this + other patches I that build on it and hence I won't be able to apply. Whilst this one is a real bug, I'm not that fussed about backporting it quickly so will probably be fine to take this via togreg once the commit message gives enough detail. Thanks, Jonathan > > --- > > drivers/iio/imu/adis16475.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/iio/imu/adis16475.c b/drivers/iio/imu/adis16475.c > > index 1de62fc79e0f..51b76444db0b 100644 > > --- a/drivers/iio/imu/adis16475.c > > +++ b/drivers/iio/imu/adis16475.c > > @@ -1068,7 +1068,7 @@ static irqreturn_t adis16475_trigger_handler(int irq, void *p) > > > > ret = spi_sync(adis->spi, &adis->msg); > > if (ret) > > - return ret; > > + goto check_burst32; > > > > adis->spi->max_speed_hz = cached_spi_speed_hz; > > buffer = adis->buffer; > > -- > > 2.31.1 > >