From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71D1FC433B4 for ; Tue, 27 Apr 2021 08:24:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 41138601FC for ; Tue, 27 Apr 2021 08:24:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234877AbhD0IYu (ORCPT ); Tue, 27 Apr 2021 04:24:50 -0400 Received: from frasgout.his.huawei.com ([185.176.79.56]:2919 "EHLO frasgout.his.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235110AbhD0IXz (ORCPT ); Tue, 27 Apr 2021 04:23:55 -0400 Received: from fraeml743-chm.china.huawei.com (unknown [172.18.147.206]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4FTvdM1s66z73dSB; Tue, 27 Apr 2021 16:12:39 +0800 (CST) Received: from lhreml710-chm.china.huawei.com (10.201.108.61) by fraeml743-chm.china.huawei.com (10.206.15.224) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Tue, 27 Apr 2021 10:23:11 +0200 Received: from localhost (10.52.123.122) by lhreml710-chm.china.huawei.com (10.201.108.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Tue, 27 Apr 2021 09:23:10 +0100 Date: Tue, 27 Apr 2021 09:21:37 +0100 From: Jonathan Cameron To: Alexandru Ardelean CC: Jonathan Cameron , linux-iio , Gene Chen Subject: Re: [PATCH 4/8] iio: adc: mt6360: Drop duplicate setting of iio_dev.dev.parent Message-ID: <20210427092137.0000663b@Huawei.com> In-Reply-To: References: <20210426170251.351957-1-jic23@kernel.org> <20210426170251.351957-5-jic23@kernel.org> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.52.123.122] X-ClientProxiedBy: lhreml720-chm.china.huawei.com (10.201.108.71) To lhreml710-chm.china.huawei.com (10.201.108.61) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Tue, 27 Apr 2021 10:25:05 +0300 Alexandru Ardelean wrote: > On Mon, Apr 26, 2021 at 8:04 PM Jonathan Cameron wrote: > > > > From: Jonathan Cameron > > > > Already set to the same value in devm_iio_device_alloc() > > > > Signed-off-by: Jonathan Cameron > > Cc: Gene Chen > > --- > > drivers/iio/adc/mt6360-adc.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/iio/adc/mt6360-adc.c b/drivers/iio/adc/mt6360-adc.c > > index 6b39a139ce28..07c0e6768391 100644 > > --- a/drivers/iio/adc/mt6360-adc.c > > +++ b/drivers/iio/adc/mt6360-adc.c > > @@ -337,7 +337,6 @@ static int mt6360_adc_probe(struct platform_device *pdev) > > } > > > > indio_dev->name = dev_name(&pdev->dev); > > unrelated to this series, this dev_name(&pdev->dev) looks a bit weird; > this should resolve to the driver name AFAICT; which is "mt6360-adc" > it feels a bit off with respect to ABI; but maybe it's too late to change it? Yup. We have some historical ones of these unfortunately when I wasn't paying attention properly. They are ABI for those parts now so we can't fix them without significant risk of breaking someones platform. Jonathan > > > - indio_dev->dev.parent = &pdev->dev; > > indio_dev->info = &mt6360_adc_iio_info; > > indio_dev->modes = INDIO_DIRECT_MODE; > > indio_dev->channels = mt6360_adc_channels; > > -- > > 2.31.1 > >