From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC3B2C433B4 for ; Mon, 3 May 2021 11:36:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 86CEA61104 for ; Mon, 3 May 2021 11:36:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233299AbhECLhG (ORCPT ); Mon, 3 May 2021 07:37:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:53660 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233108AbhECLhG (ORCPT ); Mon, 3 May 2021 07:37:06 -0400 Received: from jic23-huawei (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DB85A611CB; Mon, 3 May 2021 11:36:12 +0000 (UTC) Date: Mon, 3 May 2021 12:37:05 +0100 From: Jonathan Cameron To: Alexandru Ardelean Cc: linux-iio , Jonathan Cameron Subject: Re: [PATCH 0/8] iio: cleanup some new instances of manual parent setting. Message-ID: <20210503123705.5ecc355b@jic23-huawei> In-Reply-To: References: <20210426170251.351957-1-jic23@kernel.org> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Tue, 27 Apr 2021 10:27:44 +0300 Alexandru Ardelean wrote: > On Mon, Apr 26, 2021 at 8:04 PM Jonathan Cameron wrote: > > > > From: Jonathan Cameron > > > > It seems I still haven't trained my eyes to spot these. > > > > I think they have all been introduced since > > iio_device_alloc() and friends started setting this > > 8525df47b3d1e ("iio: core: fix/re-introduce back parent assignment") > > 78289b4a58b58 ("iio: core: pass parent device as parameter during allocation") > > > > Anyhow, all seem fairly obvious to me, but maybe I missed something so please > > take a look. > > I've added 2 comments that are unrelated [directly] to this series. > > Reviewed-by: Alexandru Ardelean Thanks for checking these. I've added the of_node dropping bit to the patch you pointed that out in. Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to poke at it and see if we missed anything! Thanks, Jonathan > > > > > Jonathan Cameron (8): > > iio: accel: bmi088: Drop manual assignment of iio_dev.dev.parent > > iio: dac: ad5766: Drop duplicate setting of iio_dev.dev.parent > > iio: adc: mp2629: Drop duplicate setting iio_dev.dev.parent > > iio: adc: mt6360: Drop duplicate setting of iio_dev.dev.parent > > iio: adc: ti-ads131e08: Drop duplicate setting of iio_dev.dev.parent > > iio: humidity: hdc2010: Drop duplicate setting of iio_dev.dev.parent > > iio: position: hid-sensor-custom-intel-hinge: Drop duplicate parent > > setting. > > iio: common: scmi_sensors: Drop duplicate setting of > > iio_dev.dev.parent > > > > drivers/iio/accel/bmi088-accel-core.c | 1 - > > drivers/iio/adc/mp2629_adc.c | 1 - > > drivers/iio/adc/mt6360-adc.c | 1 - > > drivers/iio/adc/ti-ads131e08.c | 1 - > > drivers/iio/common/scmi_sensors/scmi_iio.c | 1 - > > drivers/iio/dac/ad5766.c | 1 - > > drivers/iio/humidity/hdc2010.c | 1 - > > drivers/iio/position/hid-sensor-custom-intel-hinge.c | 1 - > > 8 files changed, 8 deletions(-) > > > > -- > > 2.31.1 > >