linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Sean Nyekjaer <sean@geanix.com>
Cc: Jonathan Cameron <jic23@kernel.org>, <linux-iio@vger.kernel.org>
Subject: Re: [PATCH v5 5/6] iio: accel: fxls8962af: add hw buffered sampling
Date: Mon, 10 May 2021 14:39:21 +0100	[thread overview]
Message-ID: <20210510143921.00001774@Huawei.com> (raw)
In-Reply-To: <f50d0b0f-f00d-35c9-9cf5-2a9e9ffaa8ca@geanix.com>

On Mon, 10 May 2021 09:54:05 +0200
Sean Nyekjaer <sean@geanix.com> wrote:

> On 08/05/2021 18.39, Jonathan Cameron wrote:
> > On Thu,  6 May 2021 09:09:39 +0200
> > Sean Nyekjaer <sean@geanix.com> wrote:
> >   
> >> When buffered sampling is enabled, the accelerometer will dump data into
> >> the internal fifo and interrupt at watermark. Then the driver flushes
> >> all data to the iio buffer.
> >> As the accelerometer doesn't have internal timestamps, they are
> >> approximated between the current and last interrupt.
> >>
> >> Signed-off-by: Sean Nyekjaer <sean@geanix.com>  
> > 
> > Hi Sean,
> > 
> > Couple of things I adjusted whilst applying this.
> > 1) trigger.h isn't used as no triggers are involved currently in this driver so
> >    I dropped it.
> > 2) kfifo allocation etc has changed in the IIO core whilst this driver was in
> >    development. Now we have devm_iio_kfifo_setup() which does everything your
> >    locals _setup() function does. 
> > 
> > I've made changes for both of the above whilst applying so please take a look
> > at the result which I'll shortly push out as testing for the autobuilders to
> > poke at as well.
> > 
> > Other than that I tweaked a bit of whilespace in the id tables in patch 1.
> > 
> > Series applied to the togreg branch of iio.git but initially just pushed out as
> > testing to let 0-day work it's magic.
> > 
> > Thanks,
> > 
> > Jonathan
> >   
> 
> Hi Jonathan,
> 
> Guess it's okay, but I can't find the patches here:
> https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git/log/?h=togreg
> 
Gah. As happens far too often I forgot to push.  It's now there as testing to
actually let the autobuilders poke a it.


> :-)
> 
> Br,
> /Sean
> 


  reply	other threads:[~2021-05-10 13:51 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-06  7:09 [PATCH v5 1/6] iio: accel: add support for FXLS8962AF/FXLS8964AF accelerometers Sean Nyekjaer
2021-05-06  7:09 ` [PATCH v5 2/6] dt-bindings: iio: accel: fxls8962af: add bindings Sean Nyekjaer
2021-05-07  0:52   ` Rob Herring
2021-05-06  7:09 ` [PATCH v5 3/6] iio: accel: fxls8962af: add set/get of samplerate Sean Nyekjaer
2021-05-06  7:09 ` [PATCH v5 4/6] iio: accel: fxls8962af: add interrupt support Sean Nyekjaer
2021-05-06  7:09 ` [PATCH v5 5/6] iio: accel: fxls8962af: add hw buffered sampling Sean Nyekjaer
2021-05-08 16:39   ` Jonathan Cameron
2021-05-10  7:54     ` Sean Nyekjaer
2021-05-10 13:39       ` Jonathan Cameron [this message]
2021-05-10 17:01         ` Sean Nyekjaer
2021-05-06  7:09 ` [PATCH v5 6/6] iio: accel: fxls8962af: fix errata bug E3 - I2C burst reads Sean Nyekjaer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210510143921.00001774@Huawei.com \
    --to=jonathan.cameron@huawei.com \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=sean@geanix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).